423672 - use runtime lookup for launch services APIs

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[(not currently active) Ted Mielczarek]

In nsMacShellService.cpp, we wound up using some undocumented Launch Services APIs. These are in the applicationservices.framework umbrella in 10.4, but have moved to the coreservices.framework in 10.5. Building with the 10.5 SDK thus results in a build that won't start on 10.4 because it can't locate those symbols. We should be looking them up at runtime instead, because they've already moved once, so we'll need to guard against that.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: replace undocumented Launch Services functions with public APIs

I'm guessing the use of undocumented LS functions dates back to earlier Mac OS X versions; as of 10.4, it looks like we can achieve the required functionality using documented, public Launch Services APIs.

I've checked that testing and setting the default browser works as expected using this patch. I've also patched GetDefaultFeedReader(), aiming to maintain the same behavior, but am not really sure how that's supposed to work, so testing would be appreciated.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: update patch so that GetDefaultFeedReader actually works

This bug is one of the handful making it difficult to build with the 10.5 SDK for deployment on 10.4 as well as 10.5. Avoiding the private LaunchServices interfaces (which might change again, or disappear entirely) should reduce risk in the future, as well as resolving the immediate issue.

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 370206 [details] [diff] [review]
update patch so that GetDefaultFeedReader actually works

> #define SAFARI_BUNDLE_IDENTIFIER NS_LITERAL_CSTRING("com.apple.Safari")

>+    defaultHandlerID = ::CFStringCreateWithCString(kCFAllocatorDefault,
>+                                                   "com.apple.Safari",

Please use SAFARI_BUNDLE_IDENTIFIER here (and drop the NS_LITERAL_CSTRING() part from the #define so that it works), or just remove the #define (since you're removing the only user).

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: updated according to mstange comment #3

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/cb053a66c9ed