423677 - misc places compiler warnings

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

I noticed some "unused variable" compiler warnings when building places components.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 310274 [details] [diff] [review]
patch

>Index: toolkit/components/places/src/nsNavBookmarks.cpp

>-    mozIStorageConnection *dbConn = DBConn();

Added in bug 332047, Marco says it can be removed.

>-  PRTime now = PR_Now();
>   rv = SetItemDateInternal(mDBSetItemLastModified, oldParent, PR_Now());
>   NS_ENSURE_SUCCESS(rv, rv);
>   rv = SetItemDateInternal(mDBSetItemLastModified, aNewParent, PR_Now());
>   NS_ENSURE_SUCCESS(rv, rv);

Intentionally changed by bug 393498. Not sure whether we should use "now" or get rid of it.

>Index: toolkit/components/places/src/nsNavHistory.cpp

>+  mUseLimit(aUseLimit),
>   mResultType(aOptions->ResultType()),
>   mQueryType(aOptions->QueryType()),
>   mIncludeHidden(aOptions->IncludeHidden()),
>   mSortingMode(aOptions->SortingMode()),
>   mMaxResults(aOptions->MaxResults()),
>-  mUseLimit(aUseLimit),
>   mSkipOrderBy(PR_FALSE)

>Index: toolkit/components/places/src/nsNavHistoryResult.cpp

>-  mDynamicContainerType(aDynamicContainerType),
>-  mOptions(aOptions)
>+  mOptions(aOptions),
>+  mDynamicContainerType(aDynamicContainerType)

Initialization order doesn't match declaration order warnings.

Comment 3

[Dietrich Ayala (:dietrich)]

> >-  PRTime now = PR_Now();
> >   rv = SetItemDateInternal(mDBSetItemLastModified, oldParent, PR_Now());
> >   NS_ENSURE_SUCCESS(rv, rv);
> >   rv = SetItemDateInternal(mDBSetItemLastModified, aNewParent, PR_Now());
> >   NS_ENSURE_SUCCESS(rv, rv);
> 
> Intentionally changed by bug 393498. Not sure whether we should use "now" or
> get rid of it.

should use "now". thanks for the patch!

Comment 5

[:Gavin Sharp [email: [e-mail]]]

From bug 424577:
bug 385245 comment 94
bug 420354 comment 25

Comment 6

[Dietrich Ayala (:dietrich)]

Attachment: more

patch updated, more warnings fixed.

Comment 7

[Asaf Romano (gone)]

Comment on attachment 315320 [details] [diff] [review]
more

r=mano

Comment 8

[Dietrich Ayala (:dietrich)]

Comment on attachment 315320 [details] [diff] [review]
more

drivers: very low risk changes to fix various warnings. safe and sane.

Comment 9

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsNavBookmarks.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp,v  <--  nsNavBookmarks.cpp
new revision: 1.162; previous revision: 1.161
done
Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.292; previous revision: 1.291
done
Checking in toolkit/components/places/src/nsNavHistoryResult.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp,v  <--  nsNavHistoryResult.cpp
new revision: 1.141; previous revision: 1.140
done

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv