423692 - Actionmonkey busted on Windows with NSPR flags and Tamarin defines

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

Attachment: Pass NSPR configure flags more correctly, rev. 1

Actionmonkey is busted on Windows. There are three different bustages, two of which I can fix here and one of which is fixed upstream and just needs a merge.

I'm pretty sure the first one here works on the big-three platforms... it will need some more cleanup later for WINCE and perhaps a few others, although perhaps we should just fix nspr-config to do the right thing all the time.

Comment 1

[Benjamin Smedberg]

Attachment: Export GCThread from MMgc.dll, and suppress bogus warnings, rev. 1

This suppresses a bogus compiler warning: class GC has members of type GCCondition, but since the constructors aren't inline you don't need GCCondition to be exported. I'm not sure why it's issuing the warning, but it should be safe to ignore.

It also export GCThread, which you do need to use MMgc.dll in threadsafe mode.

Comment 2

[Tommy Reilly]

Please move the warning disable into winbuild.h with the other ones otherwise go ahead and push it.

Comment 3

[Benjamin Smedberg]

Patches pushed to actionmonkey and tamarin-central... trying to figure out whether to commit or merge to actionmonkey-tamarin.

With the latest m-c -> actionmonkey merge Jason is doing, this should be fixed.

Comment 4

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Is this a dup of bug#428529?

Comment 5

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

In case it helps, today's builds are failing out with the following syntax error:


win32/build/dom/src/base/nsJSEnvironment.cpp
nsJSEnvironment.cpp
e:/builds/moz2-slave/actionmonkey-win32/build/dom/src/base/nsJSEnvironment.cpp(751) : error C2039: 'CompareString' : is not a member of 'nsICollation'
        e:\builds\moz2-slave\actionmonkey-win32\build\obj-firefox\dist\include\locale\nsICollation.h(100) : see declaration of 'nsICollation'
e:/builds/moz2-slave/actionmonkey-win32/build/dom/src/base/nsJSEnvironment.cpp(3273) : warning C4242: '=' : conversion from 'PRBool' to 'PRPackedBool', possible loss of data
e:/builds/moz2-slave/actionmonkey-win32/build/dom/src/base/nsJSEnvironment.cpp(3292) : warning C4242: '=' : conversion from 'PRBool' to 'PRPackedBool', possible loss of data
e:/builds/moz2-slave/actionmonkey-win32/build/dom/src/base/nsJSEnvironment.cpp(3298) : warning C4242: '=' : conversion from 'PRBool' to 'PRPackedBool', possible loss of data
e:/builds/moz2-slave/actionmonkey-win32/build/dom/src/base/nsJSEnvironment.cpp(3876) : warning C4265: 'nsJSArgArray' : class has virtual functions, but destructor is not virtual
         instances of this class may not be destructed correctly
make[6]: Leaving directory `/e/builds/moz2-slave/actionmonkey-win32/build/obj-firefox/dom/src/base'
make[5]: Leaving directory `/e/builds/moz2-slave/actionmonkey-win32/build/obj-firefox/dom/src'
make[6]: *** [nsJSEnvironment.obj] Error 2

Comment 6

[Benjamin Smedberg]

This bug, which was about the NSPR and tamarin errors, is fixed. Bug 428529, which is also about actionmonkey being busted on windows, is still a problem.