423733 - mail_delivery_method = 'Test' doesn't generate a valid mbox file

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Frédéric Buclin]

We must drop "\n\n---\n\n" and add "From - Mon Aug 20 12:57:39 2007" instead to make it a valid mbox file. This way, we can then use mail_delivery_method = 'Test' for QA and have mailer.testfile being correctly read by email clients such as Thunderbird and SeaMonkey.

This is definitely a must have for QA as that's how I check emails being sent (to fake email addresses). And I don't read encoded strings so I much prefer to let the email client decode them for me. :)

Targetting to 3.0 as that's *really* something everybody testing Bugzilla needs.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Now both Thunderbird and SeaMonkey are happy and can correctly read mailer.testfile.

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 310351 [details] [diff] [review]
patch, v1

obvious.  :)

Comment 3

[Frédéric Buclin]

tip:

Checking in Bugzilla/Mailer.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Mailer.pm,v  <--  Mailer.pm
new revision: 1.19; previous revision: 1.18
done

3.0.3:

Checking in Bugzilla/Mailer.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Mailer.pm,v  <--  Mailer.pm
new revision: 1.7.2.8; previous revision: 1.7.2.7
done

Comment 4

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.2 in a patch on bug 432331.