User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:22.214.171.124) Gecko/20080201 Firefox/126.96.36.199 Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:188.8.131.52) Gecko/20080201 Firefox/184.108.40.206 If the phishing server returns 400's, Firefox will make the request every minute, instead of just making 3 requests, and then backing off for an hour. Reproducible: Always Steps to Reproduce: 1. Have server return 400.
Summary: Phishing Backoff not working with 400's → Phishing Backoff not working with 400s
Version: unspecified → 2.0 Branch
Bumping up the priority -- we really need to get this fixed for beta 5, so that Firefox won't hammer the phishing servers if it receives 400's.
Severity: major → critical
Priority: -- → P1
Target Milestone: --- → Firefox 3 beta5
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: 2.0 Branch → Trunk
The backoff object doesn't consider 400 to be an error. This should be an easy fix, I'll attach a patch soon.
Created attachment 310401 [details] [diff] [review] trigger backoff for 400s
Assignee: nobody → dcamp
Status: NEW → ASSIGNED
Attachment #310401 - Flags: review?(tony)
Created attachment 310410 [details] [diff] [review] slightly better fix This version avoids scheduling the one-minute reping if the backoff object doesn't consider the server response worth erroring out on.
Comment on attachment 310410 [details] [diff] [review] slightly better fix This is fine, but it's also a dupe of bug 378132. This fix seems to be slightly better since we're now considering 4xx an error (that's not how we spec'ed it originally).
Attachment #310410 - Flags: review?(tony) → review+
Flags: blocking-firefox3? → blocking-firefox3+
Checking in content/listmanager.js; /cvsroot/mozilla/toolkit/components/url-classifier/content/listmanager.js,v <-- listmanager.js new revision: 1.28; previous revision: 1.27 done Checking in content/request-backoff.js; /cvsroot/mozilla/toolkit/components/url-classifier/content/request-backoff.js,v <-- request-backoff.js new revision: 1.2; previous revision: 1.1 done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
The patch in bug 378132 might be a safer basis for a branch patch, as it changes fewer interfaces (a bit). You'd want to update it to treat 4xx as errors.
Clearing branch blocking request because we took the patch in bug 378132. If we still need more please re-nominate and explain.
Dave/Garret, can you verify this bug is fixed, i think its difficult for QA to generate this Error 400 :-)
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.