423793 - disable ok button in move dialog if there's no target selected (was: "assertion failed" message if I don't select a new folder for a bookmark move)

Status: RESOLVED DUPLICATE of bug 433795

(Firefox :: Bookmarks & History, defect)

Description

[Dan]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-GB; rv:1.9b4) Gecko/2008030317 Firefox/3.0b4
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-GB; rv:1.9b4) Gecko/2008030317 Firefox/3.0b4

When I choose a "move" operation in the "All Bookmarks" Library window, and don't choose a folder in the dialogue, I get an "Assertion Failed" error sheet.

Reproducible: Always

Steps to Reproduce:
1. Select a folder in the "All Bookmarks" Library window
2. Choose "Move..." from the "Organise" button
3. Press "OK" without choosing a new folder
Actual Results:  
An "Assertion Failed" sheet pops up, with the following message:
---
ASSERT: selectedNode must be set in a single-selection tree with initial selection set
Stack Trace: 
0:MBD_onOK([object Event])
1:anonymous([object Event])
2:_fireButtonEvent(accept)
3:_doButtonCommand(accept)
4:_handleButtonCommand([object XULCommandEvent])
---

Expected Results:  
A more user-friendly error message would be nice - perhaps a message asking the user to choose a folder
OR
Disable the "OK" button until a folder has been chosen.

Comment 1

[Bob Uliss]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031404 Minefield/3.0b5pre

Pressing the OK button in this release does not do anyting - recommend change this bug to FIXED

Comment 2

[bomfog]

I think WORKSFORME is preferred if you don't know what was fixed/did the fixing.

Comment 3

[Dan]

WORKSFORME now on 3.0beta5 - As Bob said, pressing the OK button does not do anything unless a destination folder is selected.

However, this behaviour is still bad ui-wise - the OK button should be greyed out until the user chooses a destination folder.

Comment 4

[Bob Uliss]

Agreed - having an active OK button that doesn't do anything reminds me of certain politicians.
regards,

Bob

Comment 5

[Marco Bonardo [:mak]]

confirming as a UI polish

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 7

[Mark Banner (:standard8)]

Duping forward to bug 433795 as there's been more discussion there.