42384 - nsFilePicker.cpp deallocates buffer incorrectly

Status: CLOSED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Bill Law]

At 
http://lxr.mozilla.org/seamonkey/source/widget/src/windows/nsFilePicker.cpp#178
delete[] is used to deallocate a buffer obtained via nsString::ToNewCString().  
It must use nsMemory::Free.

Note that the comment for nsString::ToNewCString() is erroneous; it states that 
one must use nsString::Recycle but that function requires an nsCString as 
argument.

Comment 1

[Bill Law]

Attachment: Proposed patch; I switch to using nsMemory::Alloc/Free exclusively.

Comment 2

[Bill Law]

I've marked this [crash].  This is a blocker for nsbeta2+ work we're doing so 
this should be marked as such.  Fix is already available (as attachment).

Comment 3

[sairuh (rarely reading bugmail)]

tever...?

Comment 4

[Makoto Kato [:m_kato]]

This should be dup of bug 39902.
This code will be fixes in bug 39902.

Comment 5

[Bill Law]

fix checked in

Comment 6

[Tom Everingham]

development issues, closing