If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

"Clear List" in download manager should be "Clear Current List" during the search

RESOLVED WONTFIX

Status

()

Toolkit
Downloads API
RESOLVED WONTFIX
10 years ago
11 months ago

People

(Reporter: dynamis (Tomoya ASAI), Assigned: Mardak)

Tracking

({polish, ue})

Trunk
mozilla1.9
polish, ue
Points:
---
Bug Flags:
blocking1.9 -
wanted1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
In bug 414850 "Clear List" in download manager now only remove visible downloads.
But the label "Clear List" may make users think that this context menu will remove all download history not only currently visible ones.

To avoid confusion we should change the label dynamically when we searched and only search result are listed in the dialog.That is, we should use
  without search: Clear List
   during search: Clear All List
for the "Clear List" context menu in the download manager.

see:
https://bugzilla.mozilla.org/show_bug.cgi?id=414850#c3
https://bugzilla.mozilla.org/show_bug.cgi?id=414850#c20

note:
This is late-l10n after b5 but IMHO we should accept late-l10n like this.
Localizers don't only translate literally but we sometimes write/select better
expression for users. In some case l10n depends on the behavior of the feature
and localizers will have trouble not only with late l10n change but also with
late behavior change.

When the behavior change, it's natural to change strings and we should not be
afraid about late-l10n change. IMHO if behavior change was accepted, string change should also be accepted.
Flags: blocking-firefox3?

Comment 1

10 years ago
I'd rather have beltzner make a call here.
This definitely doesn't block. We changed the way the behaviour works in bug 414850 because we believed that it would be more common for people to interpret "Clear List" as "clear the list of things that are currently showing", which I think is still correct.

Not a bad suggestion, overall, but not something we should focus on for this release, adding wanted and ue and polish so we don't lose track.
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
Keywords: late-l10n → polish, ue
(Assignee)

Comment 3

10 years ago
Created attachment 310555 [details] [diff] [review]
v1

"Clear Current List" should work for all cases.. searching or not.

Also get rid of the clear list button's tooltip because.. we have no clear list button.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #310555 - Flags: review?(sdwilsh)
renoming - drivers please see bug 414850 comment 20 when making your decision.  I think this is pretty serious.
Flags: blocking-firefox3- → blocking-firefox3?
Comment on attachment 310555 [details] [diff] [review]
v1

>-<!ENTITY cmd.clearList.tooltip            "Removes completed, canceled, and failed downloads from the list">
I think we should probably keep this, but maybe phrase it as "Removes completed, canceled, and failed downloads from the displayed list".

regardless, r=sdwilsh - needs ui-r though.
Attachment #310555 - Flags: ui-review?(madhava)
Attachment #310555 - Flags: review?(sdwilsh)
Attachment #310555 - Flags: review+
(Assignee)

Comment 6

10 years ago
Why should we keep it around? Are we going to use it? It's not entirely correct right now either because it'll remove finished, canceled, failed, blocked parental, dirty, blocked policy downloads from the displayed list.
Right, so it needs work, but I don't feel we should get rid of it.
(Assignee)

Comment 8

10 years ago
What do we need it for? If we fix it, it just makes extra work for localizers for a string that we don't even use.
So, to be sure, before I ui-r... it will say "Clear Current List" only during a search, right?
(In reply to comment #4)
> renoming - drivers please see bug 414850 comment 20 when making your decision. 
> I think this is pretty serious.

I think that's a bug on the ja-JP locale, based on overzealous translation. Feel free to add a new localizer note, but this issue on its own doesn't block.
Flags: blocking-firefox3? → blocking-firefox3-
(Reporter)

Comment 11

10 years ago
(In reply to comment #10)
> I think that's a bug on the ja-JP locale, based on overzealous translation.
> Feel free to add a new localizer note, but this issue on its own doesn't block.

Our ja/ja-JP-mac is special case and our case is not the reason to request this bug (I also don't think this as blocker).

What I meant to say in the bug 414850 comment 20 was:
We should accept late-l10n string changes too as long as we accept behavior/feature changes since it sometimes have l10n impact.
# we should not split late-l10n deadline and behavior change deadline
Localizers also want to make better Firefox and at least our locale can accept any late-l10n string change to make better Firefox.

Thanks
(Reporter)

Comment 12

10 years ago
(In reply to comment #9)
> So, to be sure, before I ui-r... it will say "Clear Current List" only during a
> search, right?

I think it's better to say "Clear Current List" only during a search to make thing s clearer but as Edward wrote on comment #3 we can use same "Clear Curret List" label for both case as far as implementation cost is too high (in this period).

Comment 13

10 years ago
This still going to make it now Clear List is a button?
Product: Firefox → Toolkit
(In reply to comment #8)
> What do we need it for? If we fix it, it just makes extra work for localizers
> for a string that we don't even use.

i guess Shawn thought of a "cmd.clearCurrentList.tooltip" to be added with the rephrased description. why not simply use "Removes all your downloads from the displayed list" anyways?

(In reply to comment #9)
> So, to be sure, before I ui-r... it will say "Clear Current List" only during a
> search, right?
no, see comment 3.

Updated

11 months ago
Attachment #310555 - Flags: ui-review?(madhava)

Comment 15

11 months ago
This user interface was removed, and the command in Firefox is now called "Clear Preview Panel".
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.