423964 - Uninitialized var used in StorageUnicodeFunctions::likeFunction

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Daniel Veditz [:dveditz]]

The variable "E" (escape character) is used uninitialized when StorageUnicodeFunctions::likeFunction() is called with only two arguments, which seems to be how we use it because it tripped a run-time error in my debug build.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/storage/src/mozStorageUnicodeFunctions.cpp&rev=1.3&mark=198,200,209#191

I assume we can initialize this to 0 so it doesn't match anything?

Comment 1

[Daniel Veditz [:dveditz]]

Attachment: initialize 'E'

Bug is probably not a big deal, but I'd like it checked in to squash the annoying run-time error I get in debug builds.

It's old code but I haven't seen this particular warning before now. Did we just start using this method recently (or the two-arg form of it)?

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 310584 [details] [diff] [review]
initialize 'E'

is 0 right, or should we be using nsnull there?  Either way, r=sdwilsh

I suspect that this is the same as bug 420164 as well?

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 310584 [details] [diff] [review]
initialize 'E'

a1.9=beltzner

Comment 4

[Shawn Wilsher :sdwilsh]

We should have been using the two arg version for a while now, so I'm not sure why you hadn't seen it before.

Comment 5

[Daniel Veditz [:dveditz]]

Checked in