423997 - App name missing from default program description

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P2)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of description dialog

Seen using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008031806 Minefield/3.0b5pre, SP1.

STR:
1. Go to default programs and click on the Minefield icon
2. Observe the screenshot.

"Minefield" is missing from the description.

Comment 1

[Phil Ringnalda (:philor)]

I was seeing it (on an XP machine, where seeing that particular missing Minefield requires searching the registry, but you can also see the same thing from the Start Menu context menu, which should have "Minefield Options" and "Minefield Safe Mode" items) having used the installer who knows how long ago, then updated through today, but after downloading and using today's installer, I now have "Minefield" instead of " ".

Two possibilities that occur to me from that: it's the updater/updates fault, and after tomorrow's update I'll be back to blanks, or, the installer was broken at one point, and we both happen to be looking at installs that date back to having used it at that point.

Comment 2

[Robert Strong (they/them - no direct email)]

I can reproduce and this happens during the software update case. I should be able to come up with a patch tomorrow.

Comment 3

[Robert Strong (they/them - no direct email)]

btw: we use the NSIS helper.exe to update the registry after software update which is where this occurs so let's leave this as an installer bug.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1 - set the brand name vars when helper.exe runs

Comment 5

[Seth Spitzer]

Comment on attachment 310904 [details] [diff] [review]
patch rev1 - set the brand name vars when helper.exe runs

r=sspitzer, I'll leave it to robert to request approval (and to clear mconnor's review)

Comment 6

[Seth Spitzer]

(nice catch, as always, Marcia!)

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 310904 [details] [diff] [review]
patch rev1 - set the brand name vars when helper.exe runs

Simple patch to set brand name vars for helper.exe

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 310904 [details] [diff] [review]
patch rev1 - set the brand name vars when helper.exe runs

a=beltzner

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Suggested Litmus test:

 - install Firefox
 - update to next version of Firefox
 - check to make sure that the application name is in the Default Programs menu for browsing the web

Comment 10

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Checking in mozilla/browser/installer/windows/nsis/uninstaller.nsi;
/cvsroot/mozilla/browser/installer/windows/nsis/uninstaller.nsi,v  <--  uninstaller.nsi
new revision: 1.18; previous revision: 1.17
done
Checking in mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh,v  <--  common.nsh
new revision: 1.37; previous revision: 1.36
done

Comment 11

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008032605 Minefield/3.0b5pre. Added https://litmus.mozilla.org/show_test.cgi?id=5225 to the vista specific test suite.