424000 - Crash [@ nsPrintEngine::ReflowPrintObject] with semi-automated testcase2 from bug 423345

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Martijn Wargers (dead)]

I accidentally attached the testcase to bug 423345, since I thought it was the same issue, but apparently, it 's some different crash.
The testcase uses enhanced privileges, so you need to download it to your computer.

>	gklayout.dll!nsPrintEngine::ReflowPrintObject(nsPrintObject * aPO=0x04fea8c0)  Line 1839 + 0x2c bytes	C++
 	gklayout.dll!nsPrintEngine::ReflowDocList(nsPrintObject * aPO=0x04fea8c0, int aSetPixelScale=0)  Line 1799 + 0xc bytes	C++
 	gklayout.dll!nsPrintEngine::SetupToPrintContent()  Line 1607 + 0x16 bytes	C++
 	gklayout.dll!nsPrintEngine::DocumentReadyForPrinting()  Line 1439 + 0x8 bytes	C++
 	gklayout.dll!nsPrintEngine::Observe(nsISupports * aSubject=0x00000000, const char * aTopic=0x00000000, const unsigned short * aData=0x00000000)  Line 3140 + 0x8 bytes	C++
 	embedcomponents.dll!nsPrintProgress::DoneIniting()  Line 223	C++
 	xpcom_core.dll!NS_InvokeByIndex_P(nsISupports * that=0x0000000c, unsigned int methodIndex=0, unsigned int paramCount=1231800, nsXPTCVariant * params=0x00000001)  Line 102	C++
etc..

Comment 1

[Daniel Holbert [:dholbert]]

Just to have an easily clickable link: 
testcase is attachment 310485 [details]

Comment 2

[Mike Schroepfer]

Looks to be in printing and no indication of commonality of this crash - so not going to block.  If you think this is more severe please re-nom with rationale.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Still crashes.

Comment 4

[Martijn Wargers (dead)]

http://crash-stats.mozilla.com/report/index/5eed967a-6735-483f-a846-423e92100415
0  	xul.dll  	nsPrintEngine::ReflowPrintObject  	 layout/printing/nsPrintEngine.cpp:2064
1 	xul.dll 	nsPrintEngine::ReflowDocList 	layout/printing/nsPrintEngine.cpp:1864
2 	xul.dll 	nsPrintEngine::SetupToPrintContent 	layout/printing/nsPrintEngine.cpp:1674
3 	xul.dll 	nsPrintEngine::DocumentReadyForPrinting 	layout/printing/nsPrintEngine.cpp:1506
4 	xul.dll 	nsPrintEngine::FinishPrintPreview 	layout/printing/nsPrintEngine.cpp:3272
5 	xul.dll 	nsPrintEngine::Observe 	layout/printing/nsPrintEngine.cpp:3348
6 	xul.dll 	nsPrintProgress::DoneIniting 	embedding/components/printingui/src/win/nsPrintProgress.cpp:221
7 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
8 	xul.dll 	XPCWrappedNative::CallMethod 	js/src/xpconnect/src/xpcwrappednative.cpp:2750
9 	xul.dll 	XPC_WN_CallMethod 	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1770
10 	mozjs.dll 	js_Invoke 	js/src/jsinterp.cpp:835
11 	mozjs.dll 	js_Interpret 	js/src/jsops.cpp:2270
12 	mozjs.dll 	js_Invoke 	js/src/jsinterp.cpp:843
13 	mozjs.dll 	js_InternalInvoke 	js/src/jsinterp.cpp:900
14 	mozjs.dll 	JS_CallFunctionValue 	js/src/jsapi.cpp:4956
15 	xul.dll 	nsJSContext::CallEventHandler 	dom/base/nsJSEnvironment.cpp:2163
etc...

Comment 5

[Martijn Wargers (dead)]

Attachment: testcase

Comment 6

[Martijn Wargers (dead)]

Crashes on print preview.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Messing with xbl deletes for example the root scroll frame of pp.
Null check should be enough for this kind of strange situation.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/6c04c18853e3

Comment 9

[Martijn Wargers (dead)]

I get an "An unknown error occurred while printing." prompt, while trying to print preview. Is that expected?

Anyway, it doesn't crash anymore in:
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100419 Minefield/3.7a5pre
So verified fixed.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #9)
> I get an "An unknown error occurred while printing." prompt, while trying to
> print preview. Is that expected?
Yes!