Open Bug 424247 Opened 18 years ago Updated 4 years ago

Check the Content-Type when downloading Safe Browsing updates

Categories

(Toolkit :: Safe Browsing, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: gcasto, Unassigned)

Details

(Keywords: good-first-bug)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12 safebrowsing/downloads and safebrowsing/newkey requests now return a unique content-type, application/vnd.google.safebrowsing-update and application/vnd.google.safebrowsing-key. These types should be check for on download to prevent parsing garbage in captive proxy situations. Reproducible: Always
Status: UNCONFIRMED → NEW
Ever confirmed: true
Product: Firefox → Toolkit
Priority: -- → P5
Keywords: good-first-bug
OS: Windows XP → All
Priority: P5 → P2
Hardware: x86 → All
Summary: Take advantage of Content-Type of phishing requests → Check the Content-Type when downloading Safe Browsing updates
Priority: P2 → P3
Assignee: nobody → tnguyen
Assignee: tnguyen → nobody
As a first step, we should add telemetry to see if this happens often. Then we can decide whether or not to enforce the correct content-type.
Whiteboard: #sbv4-m8
Whiteboard: #sbv4-m8 → #sbv4-m9
Whiteboard: #sbv4-m9
No longer blocks: safebrowsingv4
Assignee: nobody → 1991manish.kumar
Assignee: 1991manish.kumar → nobody

Hello, my name is Erik and I'm an Outreachy candidate. Can I please be assigned this bug for my initial contribution? Thanks.

Hi Erik, thank you for reaching out.
Please ask Dimi if you have questions or need a reviewer.

Assignee: nobody → ecarr3344

(In reply to Ethan Tseng [:ethan] from comment #3)

Hi Erik, thank you for reaching out.
Please ask Dimi if you have questions or need a reviewer.

I appreciate it Ethan, will keep that in mind.

Flags: needinfo?(dlee)

Erik, did you have a specific question or just need some guidance to get start?
Please describe it when you raise the needinfo flag so people know what to respond exactly, thanks. :)

clear the needinfo since I have talked with Erik offline.

Flags: needinfo?(dlee)

(In reply to Ethan Tseng [:ethan] from comment #5)

Erik, did you have a specific question or just need some guidance to get start?
Please describe it when you raise the needinfo flag so people know what to respond exactly, thanks. :)

Sorry Ethan, I am still new to using this platform. I needed some guidance to get started but I emailed Dimi and she has responded to me already. Thanks for taking the time to address my concerns.

Hello, my name is Noor and I'm an Outreachy applicant. Can I please be assigned this bug for my initial contribution? Thanks.

(In reply to afshan.shokath from comment #8)

Hello, my name is Noor and I'm an Outreachy applicant. Can I please be assigned this bug for my initial contribution? Thanks.

Hi Noor, sorry but I am already assigned to this bug and working on it.

Status: NEW → ASSIGNED

(In reply to Erik Carrillo [:E_Carr] from comment #9)

(In reply to afshan.shokath from comment #8)

Hello, my name is Noor and I'm an Outreachy applicant. Can I please be assigned this bug for my initial contribution? Thanks.

Hi Noor, sorry but I am already assigned to this bug and working on it.

Hello,
That's OK. All the very best.

(In reply to Erik Carrillo [:E_Carr] from comment #7)

Sorry Ethan, I am still new to using this platform. I needed some guidance to get started but I emailed Dimi and she has responded to me already. Thanks for taking the time to address my concerns.

It's totally fine, don't worry. BTW, Dimi's pronoun is "he". :)

Assignee: ecarr3344 → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.