Closed
Bug 424304
Opened 16 years ago
Closed 16 years ago
Create Mochitest for bug 417760
Categories
(Firefox :: Disability Access, defect)
Firefox
Disability Access
Tracking
()
RESOLVED
FIXED
Firefox 3 beta5
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
Details
Attachments
(2 files, 2 obsolete files)
3.16 KB,
patch
|
MatsPalmgren_bugz
:
review+
MatsPalmgren_bugz
:
superreview+
|
Details | Diff | Splinter Review |
2.17 KB,
image/png
|
Details |
Mochitest needed for bug 417760 - Cannot focus img with a tabindex.
Assignee | ||
Comment 1•16 years ago
|
||
Assignee | ||
Comment 2•16 years ago
|
||
Mats, when I run the attached testcase within the chrome testharness, I get 0 passes, 0 failures, and 0 todo's. I call the "is" function twice within the testcase. If I put an alert(elemCurr); before it, I even see that theoretically both tests should pass, because I get the correct values. IOs this in principle the right approach, or am I on the wrong track somehow? Thanks for your help!
Assignee | ||
Comment 3•16 years ago
|
||
This is the Mochitest for bug 417760. Johnath helped me out with the problems I was having, so these tests now pass.
Attachment #311579 -
Attachment is obsolete: true
Attachment #311581 -
Flags: superreview?(mats.palmgren)
Attachment #311581 -
Flags: review?(mats.palmgren)
Comment 4•16 years ago
|
||
Comment on attachment 311581 [details] [diff] [review] Patch >Index: content/html/content/test/Makefile.in > test_bug408231.html \ >+ test_bug417760.html > $(NULL) You should have a backslash there. >+ <img id="img-tabindex-0" >+ src="http://trac.bitstructures.com/browser/collected/trunk/html-test-cases/greenbox.png?format=raw" I don't think we want an external ref to http://trac.bitstructures.com/ in case that server is down... Easiest is probably to include an image in the same directory and name it file_bug417760.png (that is, not using a test_ prefix). (add it to the makefile too, next to the test_ it belongs to) Not a requirement, but it would be nice with a third test: an <img> without tabindex and: // now test the img with no tabindex attr focusElem("img-no-tabindex"); checkFocus("img-tabindex-minus-1", null);
Attachment #311581 -
Flags: superreview?(mats.palmgren)
Attachment #311581 -
Flags: superreview-
Attachment #311581 -
Flags: review?(mats.palmgren)
Attachment #311581 -
Flags: review-
Assignee | ||
Comment 5•16 years ago
|
||
The one thing I didn't find out was how to actually put the .png file into the patch as well. I'll attach to the bug as a separate attachment and will ask that this be checked in along with the patch. Did I understand correctly that the image without tab index is not supposed to gain focus?
Attachment #311581 -
Attachment is obsolete: true
Attachment #311612 -
Flags: superreview?(mats.palmgren)
Attachment #311612 -
Flags: review?(mats.palmgren)
Assignee | ||
Comment 6•16 years ago
|
||
Comment 7•16 years ago
|
||
Comment on attachment 311612 [details] [diff] [review] Address Mats' comments Looks good. r+sr=mats (In reply to comment #5) > Did I understand correctly that the image without tab index is not supposed to > gain focus? Yes, calling focus() on a non-focusable element should not have any effect. Don't forget -kb when you add the image file: "cvs add -kb file_bug417760.png"
Attachment #311612 -
Flags: superreview?(mats.palmgren)
Attachment #311612 -
Flags: superreview+
Attachment #311612 -
Flags: review?(mats.palmgren)
Attachment #311612 -
Flags: review+
Assignee | ||
Comment 8•16 years ago
|
||
(In reply to comment #7) > Don't forget -kb when you add the image file: > "cvs add -kb file_bug417760.png" Thanks, will remember that for future reference, don't have CVS access yet. Do I need approval1.9 for this patch to land, or can I just request checkin?
Comment 10•16 years ago
|
||
Checking in content/html/content/test/Makefile.in; /cvsroot/mozilla/content/html/content/test/Makefile.in,v <-- Makefile.in new revision: 1.39; previous revision: 1.38 done RCS file: /cvsroot/mozilla/content/html/content/test/file_bug417760.png,v done Checking in content/html/content/test/file_bug417760.png; /cvsroot/mozilla/content/html/content/test/file_bug417760.png,v <-- file_bug417760.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/content/html/content/test/test_bug417760.html,v done Checking in content/html/content/test/test_bug417760.html; /cvsroot/mozilla/content/html/content/test/test_bug417760.html,v <-- test_bug417760.html initial revision: 1.1 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Firefox 3 → Firefox 3 beta5
You need to log in
before you can comment on or make changes to this bug.
Description
•