Build Description becomes a Build Name

RESOLVED FIXED

Status

RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: ratner, Assigned: gregaryh)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322; .NET CLR 2.0.50727; InfoPath.1)
Build Identifier: 2.0

After adding a new Build (with build description), then leaving the screen to another product, and then when you come back, the build description for a build added above becomes a new build by itself.

Reproducible: Always

Steps to Reproduce:
1. Add a new Build.
2. Add build description to the above build.
3. Leave the screen, i.e. select a different Product.
4. Come back to the previous product/build.
5. The build description entered above is listed as a new build.
Actual Results:  
Build description become a build name.

Expected Results:  
Build description should be associated with build name when a new build is created.

It only happens when the selected Milestone is '---'.  My guess is that this problem is related to the issue that I'm having with "Milestone '---' does not exist" error message that I was seen when trying to create a new build.  To get rid off this problem I set "usertargetmilestone" parameter under Task Feilds to "On", and then added '---' milestone, and set it to Default. Now I'm able to create new builds, but having this problem with build name/description.
(Assignee)

Comment 1

11 years ago
This is fixed in CVS.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

11 years ago
This appears to still be happening but only when updating a newly created build.
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---

Comment 3

10 years ago
Created attachment 341509 [details] [diff] [review]
Set build id correctly in client-side js row

Bug occurs client-side on creation of a new build.

On creating a new build, a new row is created in the ClientGrid widget.

Input focus is placed in the new row in the Name column; the user enters a name and the onGridEdit function is called for the name; bid is undefined, leading to this code being called:

        else{
            myparams.action = "add";
            myparams.name = e.value;
            myparams.milestone = Ext.getCmp('products_pane').getSelectionModel().getSelectedNode().attributes.attributes.defaultmilestone;
            myparams.isactive = 1;
        }

to get the params for the post to tr_builds.cgi

This is correct up to this point. However, upon response from the POST, it doesn't write the build id correctly into the row object clientside (writes it as "build_id", when later code looks for just "id")

Then, as the other columns are filled in, the same code is called, and bid continues to be undefined, and e.value is the value typed for each other column. Hence you erroneously get a new build created with name for the milestone/description column.
Attachment #341509 - Flags: review?(ghendricks)
(Assignee)

Comment 4

10 years ago
Comment on attachment 341509 [details] [diff] [review]
Set build id correctly in client-side js row

Good catch
Attachment #341509 - Flags: review?(ghendricks) → review+
(Assignee)

Comment 5

10 years ago
    Checking in testopia/js/build.js;
    /cvsroot/mozilla/webtools/testopia/testopia/js/build.js,v  <--  build.js
    new revision: 1.8; previous revision: 1.7
    done
Status: UNCONFIRMED → RESOLVED
Last Resolved: 11 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.