424389 - Bookmarks deleted when restoring Bookmarks by <XXX-XX-XX> menu selection

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Tracy Walker [:tracy]]

Seen with: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre)
Gecko/2008032106 Minefield/3.0b5pre

STR:

1) with a new profile, create a few bookmarks.  put some in each; Bookmarks Menu, Bookmarks Toolbar and unsorted bookmarks.
2) create a Bookmarks backup by: 
    A) Opening the Library (Bookmarks > Organize Bookmark
    B) Select Import and Backup > Backup
    C) save it as what is default (in this case: Bookmarks 2008-03-21)
3) attempt Restore from that date by Import and Backup > 2008-03-21

tested results:  The bookmarks created in step 1 are gone from the Bookmarks menu and Bookmarks toolbar. Those in unsorted are still there.

Expected results:  The bookmarks set is restored to the state as it was save to.

I know this is happening on restore and not at backup because if you choose to Restore > Choose File... it works as expected.  

This bug can't be reproduced on Mac because the Date selection doesn't exist there,  only the Choose file...

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Easy solution seems to be whenever the user does a Backup, also do/refresh the automatic daily backup. That way this case is covered. It'll break if they name their backup with yesterday's date, but I care less about that case. :)

Comment 2

[Dietrich Ayala (:dietrich)]

The patch in bug 422919 restricts the contents of the Restore menu to *.json files.

Comment 3

[Dietrich Ayala (:dietrich)]

ugh, never mind. /me needs to *read* the STR first...

Comment 4

[Dietrich Ayala (:dietrich)]

Attachment: fix v1

Comment 5

[Asaf Romano (gone)]

Comment on attachment 311459 [details] [diff] [review]
fix v1

>Index: browser/components/places/content/places.js
>===================================================================

>+  get bookmarksBackupDir() {
>+    delete this.bookmarksBackupDir;
>+    var backupDir

unused.

r=mano otherwise.

Comment 6

[Dietrich Ayala (:dietrich)]

Checking in browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.150; previous revision: 1.149
done

Comment 7

[Dietrich Ayala (:dietrich)]

Attachment: as checked in

Comment 8

[Tracy Walker [:tracy]]

Verified with Windows build from 2008042305

Comment 9

[Tracy Walker [:tracy]]

added to litmus

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 11

[Siddhant [:Siddhant085]]

The problem occurs because of the fix for bug 424389[https://bugzilla.mozilla.org/show_bug.cgi?id=1472486]. The new backup is created so that the daily backup file is updated to the point when the user manually creates a backup. I can solve this by adding in a check for the maximum number of backups before creating a new backup. If the number of backups are zero nothing is created, if the number of backups is maximum we should remove the oldest backup and add this new entry. However I am still in doubt if the default backup directory should be updated when the user manually creates a backup. The change to update the default directory was introduced by bug 424389[https://bugzilla.mozilla.org/show_bug.cgi?id=1472486]