Closed
Bug 424399
Opened 16 years ago
Closed 16 years ago
js/src/fdlibm isn't used any more, and should be removed
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jimb, Assigned: jimb)
References
Details
Attachments
(1 file, 1 obsolete file)
|
469.13 KB,
patch
|
Details | Diff | Splinter Review |
As far as I can tell, js/src/fdlibm isn't ever used any more. (If anyone knows otherwise, please say so.) So it should be removed from the source tree, along with any traces. Shaver says, 'r+a=shaver'.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #317382 -
Flags: review?
|
|
Assignee | |
Updated•16 years ago
|
Attachment #317382 -
Flags: review? → review?(shaver)
Comment on attachment 317382 [details] [diff] [review] Remove fdlibm, which is no longer used. I already said r=shaver! :)
Attachment #317382 -
Flags: review?(shaver) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
(In reply to comment #2) > (From update of attachment 317382 [details] [diff] [review]) > I already said r=shaver! :) Yay, thanks!
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: checkin-needed
|
|
Assignee | |
Comment 4•16 years ago
|
||
Comment on attachment 317382 [details] [diff] [review] Remove fdlibm, which is no longer used. Since the patch was approved, js/src/js.mak has been deleted, so this version of the patch is stale.
Attachment #317382 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•16 years ago
|
||
Update patch for current mozilla-central state. (Specifically, js/src/js.mak was deleted.)
|
||
Comment 6•16 years ago
|
||
Pushed on jimb's behalf. Changeset: http://hg.mozilla.org/mozilla-central/index.cgi/rev/2dd98957d876 Closing.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Whiteboard: checkin-needed
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•