424527 - Remove dead file jsObjectView.js

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Alex Vincent [:WeirdAl]]

http://lxr.mozilla.org/seamonkey/source/extensions/inspector/resources/content/viewers/jsObject/jsObjectView.js

is no longer packaged:

http://lxr.mozilla.org/seamonkey/source/extensions/inspector/jar.mn

Comment 1

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: remove it [Checkin: Comment 7]

Is SR needed here?

Comment 2

[[e-mail]]

Comment on attachment 426947 [details] [diff] [review]
remove it
[Checkin: Comment 7]

Probably not for an unused file, no ;-)

Comment 3

[Colby Russell :crussell (no longer Mozilla-ing)]

Comment on attachment 426947 [details] [diff] [review]
remove it
[Checkin: Comment 7]

sr+ seems sufficient

Comment 4

[Alex Vincent [:WeirdAl]]

(In reply to comment #3)
> (From update of attachment 426947 [details] [diff] [review])
> sr+ seems sufficient

I'm not sure whether to object to this or not.  True, for this purpose (removing a single unused file) it probably only needs one review.  But I don't remember ever seeing a patch where sr+ substituted for r+.

It does sound childish of me to request adherence to the rules, especially since I'm not very active in contributing to the Mozilla code base these days.  What I do believe is that it is not the patch author's decision whether sr+ seems sufficient or not, but the module owner's.

Comment 5

[Shawn Wilsher :sdwilsh]

rs=me :)

Comment 6

[Alex Vincent [:WeirdAl]]

And objection withdrawn :)

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 426947 [details] [diff] [review]
remove it
[Checkin: Comment 7]


http://hg.mozilla.org/dom-inspector/rev/2bbdd20af50a