424528 - warning: ‘isReadInDB’ may be used uninitialized in nsMsgDatabase::MarkHdrRead

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Tuukka Tolvanen (sp3000)]

In member function ‘virtual nsresult nsMsgDatabase::MarkHdrRead(nsIMsgDBHdr*, PRBool, nsIDBChangeListener*)’:
http://mxr.mozilla.org/mozilla/source/mailnews/db/msgdb/src/nsMsgDatabase.cpp#2333
warning: ‘isReadInDB’ may be used uninitialized in this function

2333   PRBool        isReadInDB;
2335   nsMsgDatabase::IsHeaderRead(msgHdr, &isReadInDB);
2341   if (bRead != isRead || isRead != isReadInDB)

http://mxr.mozilla.org/mozilla/source/mailnews/db/msgdb/src/nsMsgDatabase.cpp#1934
1934 nsresult nsMsgDatabase::IsHeaderRead(nsIMsgDBHdr *msgHdr, PRBool *pRead)
1935 {
1936   if (!msgHdr)
1937     return NS_MSG_MESSAGE_NOT_FOUND;

of course if that were to happen things would probably only actually get interesting at
2345     msgHdr->GetMessageKey(&msgKey);

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 2

[Tuukka Tolvanen (sp3000)]

a minor nit: that won't shut up the compiler warning, as the compiler still isn't actually seeing isReadInDB getting initialized in that compilation unit :)

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

Thanks Tuukka! Note to self: look at the compiler output when patching bugs about compiler warnings:)

Comment 4

[Magnus Melin [:mkmelin]]

David: ping on the r/sr

Comment 5

[David :Bienvenu]

Comment on attachment 312919 [details] [diff] [review]
proposed fix, v2

thx, Magnus.

Comment 6

[Magnus Melin [:mkmelin]]

Checking in mailnews/db/msgdb/src/nsMsgDatabase.cpp;
/cvsroot/mozilla/mailnews/db/msgdb/src/nsMsgDatabase.cpp,v  <--  nsMsgDatabase.cpp
new revision: 1.396; previous revision: 1.395
done

->FIXED