Closed
Bug 424547
Opened 17 years ago
Closed 17 years ago
Fix strings so they are more descriptive from bug 416683
Categories
(Toolkit :: Downloads API, defect, P2)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla1.9
People
(Reporter: sdwilsh, Assigned: jimm)
References
Details
(Keywords: late-l10n, Whiteboard: [1 string])
Attachments
(1 file)
2.42 KB,
patch
|
sdwilsh
:
review+
beltzner
:
ui-review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
Follow-up to bug 416683 to get more accurate strings for the download manager. This needs to land after we open up from beta 5.
Flags: blocking-firefox3?
Reporter | ||
Updated•17 years ago
|
Whiteboard: [needs patch]
Assignee | ||
Comment 1•17 years ago
|
||
Assignee | ||
Updated•17 years ago
|
Attachment #311177 -
Flags: ui-review?(beltzner)
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Reporter | ||
Updated•17 years ago
|
Whiteboard: [needs patch] → [has patch][needs ui-review beltzner]
Updated•17 years ago
|
Whiteboard: [has patch][needs ui-review beltzner] → [has patch][needs ui-review beltzner][1 string]
Reporter | ||
Comment 2•17 years ago
|
||
Comment on attachment 311177 [details] [diff] [review]
strings update for blocked by policy v.1
r=sdwilsh for code change.
Attachment #311177 -
Flags: review+
Reporter | ||
Updated•17 years ago
|
Whiteboard: [has patch][needs ui-review beltzner][1 string] → [has patch][has review][needs ui-review beltzner][1 string]
Comment 3•17 years ago
|
||
Comment on attachment 311177 [details] [diff] [review]
strings update for blocked by policy v.1
This works, but maybe: "This download has been blocked by your Windows Internet Options" would be better? That way it turns up if someone searches for that.
Attachment #311177 -
Flags: ui-review?(beltzner) → ui-review+
Reporter | ||
Updated•17 years ago
|
Whiteboard: [has patch][has review][needs ui-review beltzner][1 string] → [has patch][has review][has ui-review][1 string]
Updated•17 years ago
|
Attachment #311177 -
Flags: approval1.9?
Assignee | ||
Comment 4•17 years ago
|
||
Hmm, I'm not sure "windows internet options" actually provides better search results -
options:
http://www.google.com/search?q=Windows+Internet+Options&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:en-US:official&client=firefox-a
zones:
http://www.google.com/search?hl=en&client=firefox-a&rls=org.mozilla%3Aen-US%3Aofficial&hs=D26&q=Security+Zone+Policy&btnG=Search
That "About URL Security Zones" msdn article that comes up for the zones is really useful.
Comment 5•17 years ago
|
||
Comment on attachment 311177 [details] [diff] [review]
strings update for blocked by policy v.1
a1.9=beltzner
Attachment #311177 -
Flags: approval1.9? → approval1.9+
Updated•17 years ago
|
Keywords: checkin-needed
Comment 6•17 years ago
|
||
Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties,v <-- downloads.properties
new revision: 1.24; previous revision: 1.23
done
Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v <-- downloads.js
new revision: 1.143; previous revision: 1.142
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch][has review][has ui-review][1 string] → v <-- downloads.js new revision: 1.143; previous revision: 1.142 done v <-- downloads.properties new revision: 1.24; previous revision: 1.23 done Checking in toolkit/mozapps/downloads/content/downloads.js; /cvsroot/mozilla/toolkit/mozapps/downloads/co…
Updated•17 years ago
|
Whiteboard: Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties; /cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties v <-- downloads.js new revision: 1.143; previous revision: 1.142 done v <-- downloads… → [1 string]
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•