topcrashes [@ Compare] called from gfxWindowsPlatform::FindFontForCharProc

RESOLVED FIXED in mozilla1.9beta5

Status

()

P1
critical
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: dbaron, Assigned: pavlov)

Tracking

({crash, topcrash})

Trunk
mozilla1.9beta5
x86
Windows XP
crash, topcrash
Points:
---
Bug Flags:
blocking1.9 ?

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(1 attachment)

The other font topcrashes (bug 424165) are fixed in today's builds, but there's one new one.

There are a bunch of null-dereferences (actually, crash accessing 0x4) at the following stack:

0  	Compare(nsAString_internal const&, nsAString_internal const&, nsStringComparator const&)  	 mozilla/xpcom/string/src/nsTStringComparator.cpp:49
1 	gfxWindowsPlatform::FindFontForCharProc(nsAString_internal const&, nsRefPtr<FontFamily>&, void*) 	mozilla/gfx/thebes/src/gfxWindowsPlatform.cpp:629
2 	nsBaseHashtable<nsStringHashKey, nsRefPtr<FontFamily>, nsRefPtr<FontFamily> >::s_EnumStub(PLDHashTable*, PLDHashEntryHdr*, unsigned int, void*) 	nsBaseHashtable.h:346
3 	PL_DHashTableEnumerate 	pldhash.c:724
4 	nsBaseHashtable<nsStringHashKey, nsRefPtr<FontFamily>, nsRefPtr<FontFamily> >::Enumerate(PLDHashOperator (*)(nsAString_internal const&, nsRefPtr<FontFamily>&, void*), void*) 	nsBaseHashtable.h:221
5 	gfxWindowsPlatform::FindFontForChar(unsigned int, gfxWindowsFont*) 	mozilla/gfx/thebes/src/gfxWindowsPlatform.cpp:649

These were introduced in 2008-03-22 builds:

http://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&range_unit=weeks&version=Firefox%3A3.0b5pre&signature=Compare(nsAString_internal+const%26%2C+nsAString_internal+const%26%2C+nsStringComparator+const%26)&range_value=2
Flags: blocking1.9?
(Assignee)

Comment 1

11 years ago
Created attachment 311204 [details] [diff] [review]
fix

big thakns to vlad for spotting that you could end up with rank == matchrank == 0 and not yet have a bestMatch
Assignee: nobody → pavlov
Status: NEW → ASSIGNED
Attachment #311204 - Flags: review?(vladimir)
Attachment #311204 - Flags: review?(vladimir)
Attachment #311204 - Flags: review+
Attachment #311204 - Flags: approval1.9b5+
(Assignee)

Comment 2

11 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Priority: -- → P1
Target Milestone: --- → mozilla1.9beta5
Crash Signature: [@ Compare]
You need to log in before you can comment on or make changes to this bug.