424651 - toolbar customization page goes blank on selecting any item from 'Show:' dropdown menu

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Lorenzo]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032304 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032304 Minefield/3.0b5pre

When customizing the toolbar, clicking the dropdown menu for the customization of the buttons (text, icons, icons and text) and selecting an option causes the customization page itself to go blank.

Reproducible: Always

Steps to Reproduce:
1. Right-click toolbar and select Customize..
2. Click dropdown menu 'Show:'
3. Select any entry from menu

Actual Results:  
Customize page goes blank

Expected Results:  
Page should remain intact, dropdown menu should reflect selected option

Comment 1

[J. Gatellier]

User-Agent:   Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032404 Minefield/3.0b5pre

I'm seeing the exact same behaviour. I have to close Minefied to dismiss the blank customization page.

Comment 2

[Marcia Knous [:marcia]]

Confirming using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032404 Minefield/3.0b5pre. This is not seen on Windows and is a regression.

Comment 3

[Tony Chung [:tchung]]

Attachment: Blank customize screenshot

also confirming on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032304 Minefield/3.0b5pre.  screenshot attached.  

Windows seems okay.

Comment 4

[Marcia Knous [:marcia]]

Regression window:  

Works: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008032104 Minefield/3.0b5pre

Broken: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008032204 Minefield/3.0b5pre

In looking at the bonsai checkins, Bug 423770 seems one that touched the toolbar area.

Comment 5

[Tony Chung [:tchung]]

This is a bad user experience. but since there is no fix ready in sight, we can only relnote and nominate for blocking the rc.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

This needs to be fixed for the beta. Hoarking a user's browser is unacceptable.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

This was caused by the browser.xul patch in bug 395609. The onpopuphidden handler is being called when the dropdown menu's popup is hidden, which causes us to load about:blank. I don't think we actually need to reset to about:blank, since that change was just meant to avoid loading the customize toolbar document when it isn't needed.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 311466 [details] [diff] [review]
patch

I think oppupshowing could set the attribute only if the attribute value isn't already chrome://global/content/customizeToolbar.xul

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Attachment: updated patch

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 311470 [details] [diff] [review]
updated patch

without the checkidentity part (which isn't related to this bug) looks ok.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 311470 [details] [diff] [review]
updated patch

a1.9b5=beltzner

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Yeah, the checkIdentity part is unrelated. Tested this patch on Windows and Mac.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js 	1.1012
mozilla/browser/base/content/browser.xul 	1.455 

Comment 15

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032504 Minefield/3.0b5pre.