Closed
Bug 424661
Opened 18 years ago
Closed 18 years ago
Don't re-write the search engine list on every load
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stuart.morgan+bugzilla, Assigned: murph)
Details
(Keywords: fixed1.8.1.15)
Attachments
(1 file, 1 obsolete file)
|
6.35 KB,
patch
|
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
Right now the search engine list is re-written every time it's loaded, but since the only time it should actually change during load is the first launch or when it is edited manually, that's going to be unnecessary work most of the time. We should keep track of whether any change has been made, and only write it if so.
|
Assignee | |
Updated•18 years ago
|
Assignee: nobody → murph
|
|
Assignee | |
Comment 1•18 years ago
|
||
Additionally, the patch allows us to skip checking for duplicates and a valid preferred engine when the default information is loaded from the bundle.
Attachment #311580 -
Flags: review?(stuart.morgan)
|
Reporter | |
Comment 2•18 years ago
|
||
Comment on attachment 311580 [details] [diff] [review]
Patch
>+- (void)useDefaultSearchEngineInformationFromBundle;
s/use/load/ so the specific behavior is clear.
r=me with that change.
|
|
Reporter | |
Updated•18 years ago
|
Attachment #311580 -
Flags: review?(stuart.morgan) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Updated to reflect comment #2
Attachment #311580 -
Attachment is obsolete: true
Attachment #311604 -
Flags: superreview?(mikepinkerton)
|
|
||
Comment 4•18 years ago
|
||
Comment on attachment 311604 [details] [diff] [review]
Patch, v1.1
sr=pink
Attachment #311604 -
Flags: superreview?(mikepinkerton) → superreview+
Checked in on the trunk and MOZILLA_1_8_BRANCH.
You need to log in
before you can comment on or make changes to this bug.
Description
•