424677 - nsImapProtocol.cpp leaks nsVoidArray (4 bytes) due to static declaration

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Mark Banner (:standard8)]

I was seeing if there were any mailnews-specific instances of bug 362318, and came across this:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/imap/src/nsImapProtocol.cpp&rev=1.676&mark=321#305

Its an nsVoidArray-derived static that "leaks" 4 bytes, the same amount as on the SeaMonkey trunk tinderbox...

Its used in one place here:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/imap/src/nsImapProtocol.cpp&rev=1.676&mark=3014-3021#2998

Not quite sure of the best solution here - should we take the hit and parse custom headers each time? or could we just parse it for each nsImapProtocol instance?

Comment 1

[[e-mail]]

(In reply to comment #0)
>Not quite sure of the best solution here - should we take the hit and parse
>custom headers each time? or could we just parse it for each nsImapProtocol
>instance?
I think it would be good to parse it each time; it means the pref is live.

Comment 2

[Mark Banner (:standard8)]

Attachment: Possible Fix

I took a look at the code in a bit more detail. As I'm not sure how often the main function is called, I went for defining the array on a per-class basis and initialising it in the constructor. This definitely stops the leak.

Comment 3

[[e-mail]]

Comment on attachment 311879 [details] [diff] [review]
Possible Fix

>+    aPrefBranch->GetBoolPref("mail.imap.hide_other_users",
>                             &gHideOtherUsersFromList);
You'll want to reindent the continuation lines (& lines up with the ").

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> (From update of attachment 311879 [details] [diff] [review])
> >+    aPrefBranch->GetBoolPref("mail.imap.hide_other_users",
> >                             &gHideOtherUsersFromList);
> You'll want to reindent the continuation lines (& lines up with the ").
> 
Patch checked in with lines corrected.

This solves the final 4 byte leak on SeaMonkey's tinderbox :-)