424714 - Redirect rules don't account for letters in version numbers

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect, P1)

Description

[Jason Barnabe (np)]

Firefox version numbers can have letters in them, for example 3.0b5. I don't know if we need to document these things, but better safe than sorry.

Changing the regex to be "everything except /" would work.

Comment 1

[Mike Connor [:mconnor]]

Need this for bug 423486 to land for b5, so ASAP (tonight, if possible) would be great here.  Was originally going to hack around this on the client side, but backing away from that.

Comment 2

[Reed Loden [:reed]]

Attachment: Quick fix - v1

This is a very quick fix to get this working, but I think there's a lot of clean-up needed here. I'll file a follow-up on the other issues.

Comment 3

[Michael Morgan [:morgamic]]

Checked in, r11468.

Comment 4

[Vishal Kamdar [:vish_moz]]

Some Firefox versions also have "rc" in them for e.g. 3.0rc2
This fix only accounts for alphabet 'a' and/or 'b'. It does not account for 'r' and 'c'.
Do we care for rc?

Comment 5

[Reed Loden [:reed]]

(In reply to comment #4)
> Some Firefox versions also have "rc" in them for e.g. 3.0rc2
> This fix only accounts for alphabet 'a' and/or 'b'. It does not account for 'r'
> and 'c'.
> Do we care for rc?

No Firefox releases in the last several years have actually had "rc" in their version number. That's just marketing nomenclature.

Comment 6

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.