Redirect rules don't account for letters in version numbers

VERIFIED FIXED

Status

support.mozilla.org
General
P1
normal
VERIFIED FIXED
10 years ago
8 years ago

People

(Reporter: Jason Barnabe (np), Assigned: reed)

Tracking

unspecified
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: sumo_only urlhandling)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Firefox version numbers can have letters in them, for example 3.0b5. I don't know if we need to document these things, but better safe than sorry.

Changing the regex to be "everything except /" would work.
Need this for bug 423486 to land for b5, so ASAP (tonight, if possible) would be great here.  Was originally going to hack around this on the client side, but backing away from that.
Blocks: 423486
Priority: -- → P1
(Assignee)

Comment 2

10 years ago
Created attachment 311311 [details] [diff] [review]
Quick fix - v1

This is a very quick fix to get this working, but I think there's a lot of clean-up needed here. I'll file a follow-up on the other issues.
Attachment #311311 - Flags: review?(morgamic)
(Assignee)

Updated

10 years ago
Attachment #311311 - Attachment description: Super dirty fix - v1 → Quick fix - v1
Attachment #311311 - Flags: review?(morgamic) → review+
Checked in, r11468.
(Assignee)

Updated

10 years ago
Assignee: nobody → reed
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

8 years ago
Whiteboard: sumo_only urlhandling
Flags: in-testsuite?
Some Firefox versions also have "rc" in them for e.g. 3.0rc2
This fix only accounts for alphabet 'a' and/or 'b'. It does not account for 'r' and 'c'.
Do we care for rc?
(Assignee)

Comment 5

8 years ago
(In reply to comment #4)
> Some Firefox versions also have "rc" in them for e.g. 3.0rc2
> This fix only accounts for alphabet 'a' and/or 'b'. It does not account for 'r'
> and 'c'.
> Do we care for rc?

No Firefox releases in the last several years have actually had "rc" in their version number. That's just marketing nomenclature.
Verified, FIXED.
Status: RESOLVED → VERIFIED
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.