424757 - No focus event when returning focus to the Location bar from a search result list item

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[Marco Zehe (:MarcoZ)]

When returning focus to the location bar, no focus event is fired to indicate this.

STR:
1. Open Minefield.
2. Type in something into the Location bar that you know you have visited or bookmarked.
3. Press DownArrow to make a selection in the list of search results.
4. Press RightArrow to return to the Location bar edit combo.

Expected: Screen readers such as NVDA or JAWS should announce the focus change.
Actual: No focus change is present. AccEvent32 shows that no focus event is fired for the edit combo.

Comment 1

[Marco Zehe (:MarcoZ)]

Turns out this was broken with the initial checkin of bug 407359 already. I remember testing one of the prior patches/try server builds for that bug, where this definitely worked. But somewhere along the lines of the patch development this was broken and not caught.

Comment 2

[Damon Sicore (:damons)]

If this does indeed break the screen readers, and we regressed, we should fix this.  Can we get a confirmation that bug 407359 is really the culprit?

Comment 3

[Marco Zehe (:MarcoZ)]

Like I said above: It was meant to work in that original patch, and this functionality somehow got lost between the last try-server build I tried and the final patch that was checked in.

Comment 4

[Ginn Chen]

Attachment: patch

Comment 5

[Ginn Chen]

Attachment: patch

remove the TAB

Comment 6

[Marco Zehe (:MarcoZ)]

I tested this patch, and it does indeed fix the problem!

Ginn, any other scenarios I should try which might be affected? For example any special comboboxes or the like?

Comment 7

[Ginn Chen]

Macro, I don't know what should be tested.
I think the patch is low risk.

Comment 8

[Evan Yan]

this bug is blocking1.9+, we don't need approval1.9, do we?

Comment 9

[Marco Zehe (:MarcoZ)]

Checking in accessible/src/base/nsRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.cpp,v  <--  nsRootAccessible.cpp
new revision: 1.266; previous revision: 1.265
done

Comment 10

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040204 Minefield/3.0pre

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 312862 [details] [diff] [review]
patch

a1.9=beltzner