Closed Bug 424901 Opened 13 years ago Closed 13 years ago

Firefox Debug Build hangs on shutdown when i use the Bookmarks Preview Extension

Categories

(Core :: Security: PSM, defect, P2)

x86
macOS
defect

Tracking

()

VERIFIED FIXED
mozilla1.9

People

(Reporter: cbook, Assigned: KaiE)

References

()

Details

(Keywords: hang, Whiteboard: this bug depend on the fix of bug 420187)

Attachments

(2 files)

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032320 Firefox/3.0b5pre ID:2008032320

Steps to reproduce:
- Install the Bookmarks Preview Extension https://addons.mozilla.org/en-US/firefox/addon/6271
- Open the Places Libary
- Click through some of your Bookmarks Folder to test the Extension
- Close the Places Libary
- Close Firefox
--> Hang
this is the stack of the assertion i got shortly before the crash
I believe this is not an issue with the extension but with the Security Manager... They're running a sync main-thread event from the socket thread while the main thread is waiting on the socket thread to shut down.
Assignee: nobody → kengert
Component: General → Security: PSM
QA Contact: general → psm
s/sync main-thread event/sync main-thread proxy/
tomcat: you don't have symbols !!

is psm able to reasonably detect this, or should xpcom spin up an event loop while it waits for a thread to shutdown?

using async proxies means asking for javascript to crash
Please also see bug 420187. I have not yet looked into this one, but they seem to be related.
Are you able to test the latest patch in bug 420187 and see if it fixes this problem?
(In reply to comment #5)
> Please also see bug 420187. I have not yet looked into this one, but they seem
> to be related.
> Are you able to test the latest patch in bug 420187 and see if it fixes this
> problem?
> 

I will test the patch from bug 420187 now.
Depends on: 420187
as discussed on the meeting i have checked in the patch from bug 420187 into my debug build and i'm not anymore able to reproduce the hang from this bug Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032519 Firefox/3.0b5pre ID:2008032519

Also i got a error message during the checkin of the patch, not sure if this matter here, but want to mention this http://pastebin.mozilla.org/381053
Priority: -- → P1
Whiteboard: seems to be fixed by https://bugzilla.mozilla.org/attachment.cgi?id=310884
Target Milestone: --- → mozilla1.9beta5
+'ing this as it is confirmed to exist, and it should be fixed by bug 420187 which was also a beta blocker.  Tomcat, once confirmed to fix, please resolve this bug.
Flags: blocking1.9? → blocking1.9+
I don't think this bug, on its own, would block the beta, actually. We decided at today's Fx3 call that we'd leave this one as a P2 blocker, though it should indeed be resolved by bug 420187 - can someone confirm when that gets checked in?
Priority: P1 → P2
Target Milestone: mozilla1.9beta5 → mozilla1.9
Before you attempt to confirm the fix for this bug, please make sure you've also picked up my latest leak fix patch in bug 420187.
maybe similar issue , last few Win32 nightlies hang on exit with the Tab Sidebar extension installed (no clear STR, just browse a while and exit)
Progress on this?   Have we confirmed this was fixed by bug 420187?

As this is a hang on a debug build shutdown, I don't think this should block release at this point.  Please re-nom if you disagree.
Flags: blocking1.9+ → blocking1.9-
(In reply to comment #12)
> Progress on this?   Have we confirmed this was fixed by bug 420187?

I don't think that's possible. NSS is still using a sync proxy to the main thread from the socket thread. If the nsHttpConnectionMgr is shutting down then this will still hang, debug build or no.
(In reply to comment #13)
> (In reply to comment #12) Have we confirmed this was fixed by bug 420187? 

Do the backout (ui regression) of the first fix from Bug 420187 i still wait for a new checkin. Will test this bug asap when bug 420187 is fixed and the final patch checked in :-)
Ben: Feel free to renominate if you think this should be a blocker.
i don't think we need to block for this bug, this bug depend on bug 420187 and the latest patch there, fix also this crash/hang
Whiteboard: seems to be fixed by https://bugzilla.mozilla.org/attachment.cgi?id=310884 → this bug depend on the fix of bug 420187
Yeah, the latest patch in bug 420187 does seem to address this issue by failing if shutdown has been requested.
fixed by the checkin from bug 420187 and verified fixed tested on mac and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041217 Minefield/3.0pre ID:2008041217 with the Bookmarks Preview Extension

-> Fixed
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
also verified see comment #18
Status: RESOLVED → VERIFIED
this appears to have fixed the issue from comment #11 aswell
You need to log in before you can comment on or make changes to this bug.