424901 - Firefox Debug Build hangs on shutdown when i use the Bookmarks Preview Extension

Status: VERIFIED FIXED

(Core :: Security: PSM, defect, P2)

Description

[Carsten Book [:Tomcat]]

Attachment: apple stack from the hang on shutdown

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032320 Firefox/3.0b5pre ID:2008032320

Steps to reproduce:
- Install the Bookmarks Preview Extension https://addons.mozilla.org/en-US/firefox/addon/6271
- Open the Places Libary
- Click through some of your Bookmarks Folder to test the Extension
- Close the Places Libary
- Close Firefox
--> Hang

Comment 1

[Carsten Book [:Tomcat]]

Attachment: assertion before the crash

this is the stack of the assertion i got shortly before the crash

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I believe this is not an issue with the extension but with the Security Manager... They're running a sync main-thread event from the socket thread while the main thread is waiting on the socket thread to shut down.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

s/sync main-thread event/sync main-thread proxy/

Comment 4

[timeless]

tomcat: you don't have symbols !!

is psm able to reasonably detect this, or should xpcom spin up an event loop while it waits for a thread to shutdown?

using async proxies means asking for javascript to crash

Comment 5

[Kai Engert (:KaiE:)]

Please also see bug 420187. I have not yet looked into this one, but they seem to be related.
Are you able to test the latest patch in bug 420187 and see if it fixes this problem?

Comment 6

[Carsten Book [:Tomcat]]

(In reply to comment #5)
> Please also see bug 420187. I have not yet looked into this one, but they seem
> to be related.
> Are you able to test the latest patch in bug 420187 and see if it fixes this
> problem?
> 

I will test the patch from bug 420187 now.

Comment 7

[Carsten Book [:Tomcat]]

as discussed on the meeting i have checked in the patch from bug 420187 into my debug build and i'm not anymore able to reproduce the hang from this bug Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032519 Firefox/3.0b5pre ID:2008032519

Also i got a error message during the checkin of the patch, not sure if this matter here, but want to mention this http://pastebin.mozilla.org/381053

Comment 8

[Damon Sicore (:damons)]

+'ing this as it is confirmed to exist, and it should be fixed by bug 420187 which was also a beta blocker.  Tomcat, once confirmed to fix, please resolve this bug.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

I don't think this bug, on its own, would block the beta, actually. We decided at today's Fx3 call that we'd leave this one as a P2 blocker, though it should indeed be resolved by bug 420187 - can someone confirm when that gets checked in?

Comment 10

[Kai Engert (:KaiE:)]

Before you attempt to confirm the fix for this bug, please make sure you've also picked up my latest leak fix patch in bug 420187.

Comment 11

[Peter van der Woude [:Peter6]]

maybe similar issue , last few Win32 nightlies hang on exit with the Tab Sidebar extension installed (no clear STR, just browse a while and exit)

Comment 12

[Damon Sicore (:damons)]

Progress on this?   Have we confirmed this was fixed by bug 420187?

As this is a hang on a debug build shutdown, I don't think this should block release at this point.  Please re-nom if you disagree.

Comment 13

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #12)
> Progress on this?   Have we confirmed this was fixed by bug 420187?

I don't think that's possible. NSS is still using a sync proxy to the main thread from the socket thread. If the nsHttpConnectionMgr is shutting down then this will still hang, debug build or no.

Comment 14

[Carsten Book [:Tomcat]]

(In reply to comment #13)
> (In reply to comment #12) Have we confirmed this was fixed by bug 420187? 

Do the backout (ui regression) of the first fix from Bug 420187 i still wait for a new checkin. Will test this bug asap when bug 420187 is fixed and the final patch checked in :-)

Comment 15

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Ben: Feel free to renominate if you think this should be a blocker.

Comment 16

[Carsten Book [:Tomcat]]

i don't think we need to block for this bug, this bug depend on bug 420187 and the latest patch there, fix also this crash/hang

Comment 17

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Yeah, the latest patch in bug 420187 does seem to address this issue by failing if shutdown has been requested.

Comment 18

[Carsten Book [:Tomcat]]

fixed by the checkin from bug 420187 and verified fixed tested on mac and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041217 Minefield/3.0pre ID:2008041217 with the Bookmarks Preview Extension

-> Fixed

Comment 19

[Carsten Book [:Tomcat]]

also verified see comment #18

Comment 20

[Peter van der Woude [:Peter6]]

this appears to have fixed the issue from comment #11 aswell