Closed
Bug 424916
Opened 17 years ago
Closed 17 years ago
Tighten up charset autodetection code
Categories
(Core :: Internationalization, defect, P1)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla1.9beta5
People
(Reporter: smontagu, Assigned: smontagu)
References
Details
Attachments
(1 file)
|
11.23 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
damons
:
approval1.9b5+
|
Details | Diff | Splinter Review |
Turning off the individual charset detectors when we encounter illegal sequences isn't really necessary. Cutting it out doesn't seem to cause either misdetections or a performance hit.
There are also two directories that aren't even built: intl/chardet/classic and intl/chardet/windows, which we can remove completely. The attached patch doesn't include the removal, but I'll do it when checking in.
Attachment #311507 -
Flags: review?(dbaron)
Comment on attachment 311507 [details] [diff] [review]
Patch
r+sr=dbaron
Attachment #311507 -
Flags: superreview+
Attachment #311507 -
Flags: review?(dbaron)
Attachment #311507 -
Flags: review+
|
Assignee | |
Updated•17 years ago
|
Attachment #311507 -
Flags: approval1.9b5?
|
||
Comment 2•17 years ago
|
||
+'ing, w/ P1. TM=Beta 5. This must have beta testing.
Flags: blocking1.9+
Priority: -- → P1
Target Milestone: --- → mozilla1.9beta5
|
|
||
Comment 3•17 years ago
|
||
Comment on attachment 311507 [details] [diff] [review]
Patch
a1.9b5+=damons
Attachment #311507 -
Flags: approval1.9b5? → approval1.9b5+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 5•17 years ago
|
||
Bug 426271 seems to be regression of this bug.
Depends on: 426271
You need to log in
before you can comment on or make changes to this bug.
Description
•