42492 - overflow:scroll no longer shows scrollbars on textarea

Status: RESOLVED WORKSFORME

(Core :: Layout: Form Controls, defect, P2)

Description

[rods (gone)]

Not that long ago both scrollbars were showing for textareas and this made them 
visually compatiable with Nav 4.x. The textareas no longer have scrollbars, and 
adding the rule overflow:scroll no longer works.

Comment 1

[rods (gone)]

nominatiing for nsbeta2 because it is a regression and the textarea should 
really look like a textarea

Comment 2

[Peter Trudelle]

need info: is this breaking any of the NS6 apps?  How many users will see this?

Comment 3

[rods (gone)]

It doesn't keep people from doing work but textarea don't look like a textarea 
without this fix

Comment 4

[Phil Peterson]

[nsbeta2-] added nsbeta3 keyword

Comment 5

[mjudge]

more work for evaughn i think. We need a way to turn on/off enable/disable 
scrollbars on scrollframes. assigning to evaughn.

Comment 6

[Hixie (not reading bugmail)]

As per meeting with ChrisD today, taking QA.

Comment 7

[Peter Trudelle]

nsbeta3+, reassigning to hyatt who knows of a trivial fix.

Comment 8

[Peter Trudelle]

P4

Comment 9

[David Hyatt]

This bug is contingent on fixing 46505.  Once I get the <div> in XBL, I can work 
the appropriate mojo to fix this bug.

Comment 10

[David Hyatt]

trudelle --> p3

Comment 11

[David Hyatt]

fixed.  i added support for overflow:hidden as well, since it also made sense to 
me.

Comment 12

[rods (gone)]

Reopening bug because change had to be backed out to fix tree breakage.

Comment 13

[David Hyatt]

fixed without breakin the mac this time. :)

Comment 14

[Hixie (not reading bugmail)]

Chris, maybe you understand how to verify this. ;-)

Comment 15

[ckritzer (gone)]

Okay.

Grayed-out (non-usable) scrollbars do *not* appear on Seamonkey for a text area 
in which the text is completely visable.  Scrollbars automaticly appear 
(horizontal & vertical) when the rows/cols are too small for the text to be 
completely visable.  Peachy, as long as that is the expected behaviour.

Rod, I've attached a simple testcase with two textarea fields.  Each contains 
the same text and textspacing, with the exception that the first has rows=5 
cols=10 and the second has rows=10 cols=40.

Do they look and behave as expected?  Judging by your original comments, I'm 
tempted to re-open the bug.

Comment 16

[ckritzer (gone)]

Attachment: simple testcase

Comment 17

[rods (gone)]

textareas are suppose have "overflow:scroll;" in the html.css and this has been 
removed. The idea was that the scrollbars should always be visible for textareas 
which is why I filed this bug. So when I put it back in it works fine. So this 
is now fixed.

Comment 18

[ckritzer (gone)]

Okay, I think I understand, and I'm gonna parrot it back to be absolutely 
certain:

1) "overflow:scroll" was checked in and worked, but broke the mac
2) "overflow:scroll" was backed out
3) "overflow:scroll" was put back in with no problems, and now works fine.

And what "overflow:scroll" does is force the scroll bars to appear even when 
there is really no text to scroll.

Did I get it?

Comment 19

[David Hyatt]

You have to put overflow: scroll on a textarea to verify this bug.

Comment 20

[Hixie (not reading bugmail)]

reopening, since we need to update html.css to have this...

hyatt: as per e-mail discussion, please implement overflow:-moz-* on textarea 
then modify the html.css file (adding one line).

Note that we still want a horizontal scrollbar if we need one, and always want
a vertical scrollbar.

Comment 21

[Peter Trudelle]

clearing nsbeta3+ for re-consideration.

Comment 22

[David Hyatt]

I don't know the exact moz props.  Could you show me the sample rules that I'd 
use to do what you want?

Comment 23

[David Hyatt]

There's no way this is going to get + by anyone on XPToolkit.  If you guys want 
to do this, it should probably be + and handled by someone in layout.  I'm happy 
to show you the right place in the code to patch.

Comment 24

[rods (gone)]

Dave, please add a patch file with what we need to do to fix this. Thanks

Comment 25

[David Hyatt]

Check out line 1722 or so in nsGfxTextControlFrame2.cpp.  Just add the 
individual moz-overflow cases to the series of if/else statements.

Comment 26

[Kevin McCluskey (gone)]

Marking nsbeta3-. Agreed that a textarea should look like a textarea but this is 
really a polish issue. Not enough time before nsbeta3 to fix it.

Comment 27

[rods (gone)]

reassigning back to xptoolkit because we won't get to it either. Hyatt you may 
want to assign this to evaughan

Comment 28

[Boris Zbarsky [:bzbarsky]]

jkeiser, wanna do this?  ;)

Comment 29

[Pascal Chevrel:pascalc]

Attachment: new testcase

This is a new testcase with overflow:scroll explicitly set.

Comment 30

[Pascal Chevrel:pascalc]

it looks ok to me with build 2003041508. If drivers think that overflow.scroll
should be the default behaviour, perhaps the bug summary should be changed,
otherwise I think it should be marked as fixed.

Comment 31

[John Keiser (jkeiser)]

I'm not clear what we want to do here.  It sounds like the bug was originally
that textareas should always have scrollbars on no matter what, and others are
saying that didn't work, but Pascal's testcase shows that it does.

I think IE's behavior is pretty sane; we should turn on scrollbars but show them
greyed out if the area is not big enough to scroll.  We should probably do that
for overflow:scroll in all cases.

Comment 32

[Anne (:annevk)]

Is this still an issue? And if comment 20 is the way to go:

> Note that we still want a horizontal scrollbar if we need one, and always
> want a vertical scrollbar.

We need to fix bug 72747

Comment 33

[Boris Zbarsky [:bzbarsky]]

This worksforme (as described).

Changes to the default overflow value should go into other bugs (make sure to cc
Ian and David on those).