424940 - please include VERSIONINFO from all libraries

Status: NEW

(Toolkit :: Crash Reporting, enhancement)

Description

[timeless]

the ms crash reporter does this, and while it's generally absolutely useless, it would save me time when I try to hunt for plugin vendors.

Comment 1

[(not currently active) Ted Mielczarek]

The minidump format doesn't actually support this in the module struct, and we don't actually write the minidump directly on Windows (we use DbgHelp.dll), so this would be a pain to do. We'd have to store the data separately, and collect it after the dump is written. Seems unlikely to happen.

Comment 2

[Benjamin Smedberg]

Then hrm, how does the MS crashreporter do it?

I agree, we shouldn't fix this outside of breakpad.

Comment 3

[Jonathan Watt [:jwatt]]

The following recent report, which is a Windows crash, seems to have the version numbers for all libraries except mozjs.dll - is this bug fixed?

https://crash-stats.mozilla.com/report/index/e98c9a13-236a-4d76-9cdb-76e302110703

Comment 4

[(not currently active) Ted Mielczarek]

No, VERSIONINFO is more than just version numbers, it also includes the vendor name etc. I don't have any immediate plans to add this, but it would probably be nice.

Comment 5

[Gabriele Svelto [:gsvelto]]

Note to myself since we'd like to do this eventually, to read the version information from a DLL one needs to:

1. Call GetFileVersionInfoSize() to get the size of the version information
2. Call GetFileVersionInfo() to read the version information (passing the size we got in 1)
3. Call VerQueryValue() on the file version with the \VarFileInfo\Translation paramter to fill a LANGANDCODEPAGE struct
4. Call VerQueryValue() again to read the info we need. Some example code of the last two steps is available here

The strings we can read are listed here, in the table at the bottom of the page.