424945 - Use selected weight for font cache

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Stuart Parmenter]

Attachment: fix

Because the FontEntry always knows the actual weight we're going to use we can use it for doing cache lookups instead of say, 401 or 402 which don't really map to anything.  This will reduce GDI object usage a lot in cases where you have lots of fonts on a page and bolder/lighter (or simply have font weight misses like 600 and 700 when you only have a 700).  Also, if there is no size adjust, pre-round size so we can add some additional reuse.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 311529 [details] [diff] [review]
fix

Looks fine here.

Comment 2

[John Daggett (:jtd)]

We should probably put together a Mac version of this, I'll work on setting up a patch.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Did this regress Thai somehow?  See the "what's happen with thai language after FF3.0b5 nightly build 	27032008??" thread in m.d.a.firefox.

Comment 4

[Mike Shaver (:shaver emeritus)]

Discussion in d-a-f indicates that this bug may have regressed Thai display from

http://www.firefoxthai.com/forum/image/images/4266sss.jpg

to

http://www.firefoxthai.com/forum/image/images/7767ttt.jpg

Comment 5

[Stuart Parmenter]

I don't see how, but feel free to file a new bug and I'll investigate.