424995 - remove countdown timer from software update UI

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Deb Richardson [:dria] (plz NEEDINFO)]

When I click the Growl software update notification from Minefield, the "Details" link on the dialog is focused for a second or two before the "Restart Minefield" button gets focus.  I almost always end up hitting "Enter" during this time, opening a new window displaying the details page rather than restarting Minefield like I intend.

Comment 1

[Mike Connor [:mconnor]]

Now that we don't pop the dialog unless the user invokes it or is idle, we can safely remove the delay here.

-> Dao, this should be quick and easy, please request review from me when its ready.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Comment 3

[Dão Gottwald [:dao]]

gUpdates.wiz.getButton("finish").focus(); didn't work for me without a timeout ... not sure why.

Comment 4

[Dão Gottwald [:dao]]

i.e. it seemed to be a no-op, "Details" was still focused.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> gUpdates.wiz.getButton("finish").focus(); didn't work for me without a timeout
> ... not sure why.

You're probably racing with wizard.xml's _setInitialFocus, which is called from a timeout in an onload listener (much like updates.js' onLoad). It uses a timeout because of bug 103197, but I think things have changed enough since then that it's no longer necessary. Can you at least file a bug to investigate removing that timeout, so that we can remove the one you're adding?

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch

Filed bug 426021. Adding that reference to the patch.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 312573 [details] [diff] [review]
patch

r=mconnor, thanks

Comment 8

[Reed Loden [:reed]]

Checking in toolkit/mozapps/update/content/updates.js;
/cvsroot/mozilla/toolkit/mozapps/update/content/updates.js,v  <--  updates.js
new revision: 1.82; previous revision: 1.81
done