425087 - nsHTMLImageElement::IsFocusable needs more work

Status: RESOLVED INCOMPLETE

(Core :: DOM: Core & HTML, defect, P5)

Description

[Mats Palmgren (inactive)]

Followup from bug 417760 comment 6:

1. we should return false if !IsInDoc(), not just for image map:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/content/html/content/src/nsHTMLImageElement.cpp&rev=1.224&root=/cvsroot&mark=442#436
   and a better test is probably what nsGenericHTMLElement::IsFocusable does:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/content/html/content/src/nsGenericHTMLElement.cpp&rev=1.756&root=/cvsroot&mark=3119-3127,3133#3116

2. this block should be removed?:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/content/html/content/src/nsHTMLImageElement.cpp&rev=1.224&root=/cvsroot&mark=461-464#436
   <input type="image"> is not handled by this method, if that
   was the assumption

We should refactor these methods (post-1.9) such that a subclass
IsFocusable() can re-use common code from a superclass...

Comment 1

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

The code changed a lot since the bug was filed. nsHTMLImageElement::IsFocusable is no longer in the current m-c, though HTMLImageElement::IsHTMLFocusable may serve the similar purpose. Anyway, a lot of refactoring happened in the past 16 years. Please feel free to file a new bug.