425161 - Add versioning to left pane folder (replace queries before final)

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Marco Bonardo [:mak]]

Some blocker bug require us to replace library left pane queries, or only new profiles will have the fixes.

To start with a levelled up userbase (and help QA & support) we must ensure that all users will have the same queries with the same properties (like readonly, etc.)

So while there we must add a versioning annotation to left pane, that will allow us to update queries in future with minor headache.

This should be really done before final.

Comment 1

[Mike Connor [:mconnor]]

Need to get some sort of SWAG on this.

Comment 2

[Marco Bonardo [:mak]]

need to look deeper but should not be an hard one, change current anno (already exists) setting a value inside it (version), and discard older folders.
hwv this has to wait for 419731 before check-in to be more effective, but will try to have a first wip patch before.

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch

add versioning.

Notice that actually we are setting the annotation with value TRUE that is translated into the db as 1. So we can checkin this also now, and will not have any problem or different behaviour since version 1 is current.

The only thing that we will have to do then is bumping up version to 2 when all leftpane relative bugs will be checked-in to upgrade beta users. (or alternatively we can wait to check this is and check-in with version already set up to 2)

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch

minor change

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch

moved const to the top

Comment 6

[Asaf Romano (gone)]

Comment on attachment 314572 [details] [diff] [review]
patch

r=mano

Comment 7

[Marco Bonardo [:mak]]

Attachment: with version bump

this already includes version bump

don't check-in until we have not finished with blockers regarding the Library left pane

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 314572 [details] [diff] [review]
patch

a1.9=beltzner

Comment 9

[Damian Shaw [Quan]]

Could bug 426649 possibly affect this bug?

Comment 10

[Marco Bonardo [:mak]]

(In reply to comment #9)
> Could bug 426649 possibly affect this bug?

it should not

Comment 11

[Asaf Romano (gone)]

mozilla/browser/components/places/content/utils.js 1.136

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks like this landed without any issue. Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008052104 Minefield/3.0pre ID:2008052104

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv