425171 - Change duplicated accesskeys in Copies and Folders panels

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9b5pre) Gecko/2008032504 Minefield/3.0b5pre
Build Identifier: 

Copies and Folders panels in the account Manager have some duplicated accesskeys ans ome poorly choosen ones. Patch attached.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Giacomo Magnini]

Attachment: That should be enough (SM only)

Comment 2

[Robert Kaiser]

Comment on attachment 311776 [details] [diff] [review]
That should be enough (SM only)

>Index: suite/locales/en-US/chrome/mailnews/pref/am-copies.dtd
>===================================================================
> <!ENTITY draftInOtherFolder.label "Other:">
> <!ENTITY draftInOtherFolder.accesskey "t">

While you're there, please change this one to "h" as "t" is pretty narrow in the UI and should only be used if no wider character is available.
r=me with that.

Comment 3

[Robert Kaiser]

And as with the other such bugs: We share the XUL with Thunderbird, so please check if they have the same problem and file a bug or patch for them if so.

Comment 4

[Giacomo Magnini]

Can't use h as it is used under Windows for Help. Will provide updated patch including TB stuff.

Comment 5

[Giacomo Magnini]

Attachment: Updated, with TB changes as well

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 312718 [details] [diff] [review]
Updated, with TB changes as well

r=me, thanks!

Comment 7

[[e-mail]]

(In reply to comment #4)
>Can't use h as it is used under Windows for Help.
Nice of you to mention this, unfortunately it seems to have been accidentally removed as part of the checkin to bug 299424 ?!

Comment 8

[Giacomo Magnini]

Good luck trying to back that part out! :-P

Comment 9

[Reed Loden [:reed]]

Checking in suite/locales/en-US/chrome/mailnews/pref/am-copies.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/mailnews/pref/am-copies.dtd,v  <--  am-copies.dtd
new revision: 1.22; previous revision: 1.21
done
Checking in mail/locales/en-US/chrome/messenger/am-copies.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/am-copies.dtd,v  <--  am-copies.dtd
new revision: 1.6; previous revision: 1.5
done

Comment 10

[Giacomo Magnini]

Verified with build id: 2008040501