425173 - Change duplicated accesskeys in Junk Settings panels

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9b5pre) Gecko/2008032504 Minefield/3.0b5pre
Build Identifier: 

There are two duplicated accesskeys in the Junk Settings panel (r, A) and a badly chosen one. Patch attached.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Giacomo Magnini]

Attachment: Prototype fix (SM only)

Comment 2

[Robert Kaiser]

Comment on attachment 311779 [details] [diff] [review]
Prototype fix (SM only)

>Index: suite/locales/en-US/chrome/mailnews/pref/am-junk.dtd
>===================================================================
> <!ENTITY junkFolderOn.label "&quot;Junk&quot; folder on:">
>-<!ENTITY junkFolderOn.accesskey "u">
>+<!ENTITY junkFolderOn.accesskey "k">

I'd use "J" here.
Use the first letter where possible (and uppercase J is wide enough to make the underline well-visible in the UI, lowercase one would be bad).

r=me with that change.

Comment 3

[Robert Kaiser]

Oh, and as we share the XUL with Thunderbird, please check if they have the same problem and file a bug or patch for them if so.

Comment 4

[Giacomo Magnini]

Well, J is not very nice under linux (the underscore crosses the lower part of the letter, at least on my system), but we can live with that. Will change and fix TB as well.

Comment 5

[Giacomo Magnini]

Attachment: As per review comments, TB too

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 312717 [details] [diff] [review]
As per review comments, TB too

r=me, thanks

Comment 7

[Reed Loden [:reed]]

Checking in suite/locales/en-US/chrome/mailnews/pref/am-junk.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/mailnews/pref/am-junk.dtd,v  <--  am-junk.dtd
new revision: 1.3; previous revision: 1.2
done
Checking in mail/locales/en-US/chrome/messenger/am-junk.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/am-junk.dtd,v  <--  am-junk.dtd
new revision: 1.3; previous revision: 1.2
done

Comment 8

[Giacomo Magnini]

Verified with build id: 2008040501