425529 - Undo function does not work for deleted tags in the Library

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008032704 Minefield/3.0pre ID:2008032704

When you delete a tag within the Library it is not possible to undo the step. The deleted tag is definitely gone. Doing the same with a bookmark restores it on the old place.

Steps to reproduce:
1. Open the Library and tag a bookmark
2. Goto "Tags" and click the new tag
3. Select the bookmark under this tag and hit delete
4. Goto "Edit | Undo"

The deleted tag should be restored but it's not done at the moment. There is no chance to get back a deleted tag. Setting keyword dataloss accordingly.

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

I see same in Windows/Vista HP 
Existing tagged bookmarks can be 'undone' 
but a New tag created in the Organizer, once deleted cannot be 'undone' 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008032705 Minefield/3.0pre Firefox/3.0 ID:2008032705

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #1)
> Existing tagged bookmarks can be 'undone' 
> but a New tag created in the Organizer, once deleted cannot be 'undone' 

What do you mean with existing tagged bookmarks? I did following steps and it also doesn't work:

1. Open a website and hit Cmd+D.
2. Give the bookmark a tag
3. Open Library and delete the entry under this tag
=> Undo doesn't work.

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

I mean a bookmark that I had tagged some time ago, seems to be able to be 'undone'.  

Appears that the creation of new tags is the problem then. 

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Regression from between 2008-02-01 and 2008-03-01. Will try to get the regression window tomorrow.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This regressed between 20080206-04 and 20080207-04.

Checkins within this timeframe:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-02-06+03%3A00%3A00&maxdate=2008-02-07+04%3A00%3A00&cvsroot=%2Fcvsroot

Possible related: bug 332047, bug 411088

I think this is caused by the patch on bug 411088. Seems that we fail because we cannot undo the deletion of a formerly empty tag.

I hope it's ok to set Asaf as assignee for this bug because his patch caused this issue.

Comment 6

[Asaf Romano (gone)]

Attachment: patch

Comment 7

[Dietrich Ayala (:dietrich)]

Comment on attachment 313075 [details] [diff] [review]
patch

r=me. are there other instances of container ids passed to the tagging APIs that might be afflicted this way?

Comment 8

[Asaf Romano (gone)]

No, as far as I know.

Comment 9

[Asaf Romano (gone)]

mozilla/browser/components/places/src/nsPlacesTransactionsService.js 1.35

Comment 10

[Jim Jeffery not reading bug-mail 1/2/11]

Verified Fixed Windows Vista HP SP1

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008040212 Minefield/3.0pre Firefox/3.0 ID:2008040212

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008040504 Minefield/3.0pre ID:2008040504

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008040504 Minefield/3.0pre ID:2008040504

Comment 12

[Aakash Desai [:aakashd]]

Test case https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=7469 has been added to litmus for regression testing.

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv