425588 - "Go to line" should always parse line number as decimal

Status: VERIFIED FIXED

(Toolkit :: View Source, defect)

Description

[Masahiro YAMADA]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008032705 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008032705 Minefield/3.0pre

"Go to line" of View Source parses inputred line number with parseInt(arg).

When arg is "010", it jumps to line 8, not line 10.
When arg is "08",  error message is displayed, not goes to line 8.

I think , we use parseInt(arg,10) instead of parseInt(arg)



Reproducible: Always

Steps to Reproduce:
1.Show source of some web page
2.Open Go To Line dialog via Edit > Go to line
3.enter "010"
Actual Results:  
It jumps to line 8.


Expected Results:  
it should jump to line 10.

Comment 1

[Masahiro YAMADA]

Attachment: Patch rev.1.0

I think same fix is needed  for
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/suite/browser/viewsource.js&rev=1.50

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 312187 [details] [diff] [review]
Patch rev.1.0

Looks fine to me, but please get review from a toolkit peer (see http://www.mozilla.org/projects/toolkit/review.html).

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 312187 [details] [diff] [review]
Patch rev.1.0

does toolkit need sr?

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 312187 [details] [diff] [review]
Patch rev.1.0

r=me (wow latency)

uber-nit: space after comma.

Comment 5

[Masahiro YAMADA]

Comment on attachment 312187 [details] [diff] [review]
Patch rev.1.0

line 153 is not correct part to fix on this bug.

Comment 6

[Masahiro YAMADA]

Attachment: Patch Rev.2.0

Previous patch cannot fix this problem.
Sorry for spam.

Comment 7

[Atsushi Sakai]

In toolkit, superreview is not needed and review is enough, isn't it?

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://hg.mozilla.org/mozilla-central/rev/ca8cf5405bd4

(In reply to comment #7)
> In toolkit, superreview is not needed and review is enough, isn't it?

Exactly.

Comment 9

[Masahiro YAMADA]

-->VERIFIED
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090618 Minefield/3.6a1pre