425611 - Item annotations don't support EXPIRE_WITH_HISTORY

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dan Mills [:thunder]]

And the docs in devmo and in the idl itself don't make it clear that you can't use it for setItemAnnotation.

We should a) document that it doesn't work, and b) have an EXPIRE_WITH_ITEM to match.  The closest thing I see is EXPIRE_NEVER, but the idl clearly states that it will then live in the db forever.  Or is that not true in the case of items?

As a related problem, the idl also doesn't mention that from JS I don't need to worry about nsIVariants.  I know everything gets magically marshalled now, but since I was getting NS_ERROR_ILLEGAL_VALUE I spent a while trying to create nsIVariants to pass in.

Comment 1

[Marco Bonardo [:mak]]

idl comments are going to be fixed in bug 317472
i'll add a comment stating that expire_with_history is not supported on item annotations.

EXPIRE_NEVER really expire when an item gets deleted from the db (bug 317472 will fix the wrong behaviour for page annotations)

Comment 2

[Dan Mills [:thunder]]

Thanks!  Sounds great.

Comment 3

[Marco Bonardo [:mak]]

comments have been added so now expiration const should be clear enough
fixed in bug 317472

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv