425620 - checksetup.pl doesn't pick up the user's language correctly

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Marc Schumann [:Wurblzap]]

This may be Windows-only: setlocale() may return strings in the form of German_Germany.1252. This is unsuitable because expects language codes (de_DE.1252 would be good instead).

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Fixes issue. This patch assumes the patch of bug 425288 to be applied.

Comment 2

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.1

Comment 3

[Frédéric Buclin]

Comment on attachment 312688 [details] [diff] [review]
Patch 1.1

>+use Locale::Language;

This looks good (I didn't test as I don't have Windows in hands right now), but manpage of Locale::Language says:

KNOWN BUGS AND LIMITATIONS
       ·   In the current implementation, all data is read in when the module is loaded, and then
           held in memory.  A lazy implementation would be more memory friendly.

So as we only need this module in get_console_locale() which is only called by checksetup.pl, i.e. is never used under normal Bugzilla usage, couldn't we remove this line and write "require Locale::Language" in get_console_locale() to not load it all the time? As Bugzilla::Install::Util is used by Bugzilla::Template, we would load it for all pages, which would eat useless memory. r=LpSolit with this small change (you will then have to explicitly call Locale::Language::language2code() or import this method first). Carry forward my r+ on the updated patch.

Comment 4

[Frédéric Buclin]

Holding approval till the patch is updated.

Comment 5

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.1.1

Good idea. This patch does this. It works as well.

Comment 6

[Marc Schumann [:Wurblzap]]

Checking in Bugzilla/Install/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Util.pm,v  <--  Util.pm
new revision: 1.13; previous revision: 1.12
done