Remove all "isEmpty then return false" portions from MSAA methods.

RESOLVED FIXED in mozilla1.9

Status

()

Core
Disability Access APIs
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: MarcoZ, Assigned: MarcoZ)

Tracking

({access})

Trunk
mozilla1.9
x86
Windows XP
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
But leave the IA2 ones intact. This is to better guarantee interoperability with older screen readers that don't use IA2 for Firefox 3 yet, such as JAWS 8.
(Assignee)

Comment 1

10 years ago
Created attachment 312280 [details] [diff] [review]
Remove the "if isempty then return false" blocks from MSAA related methods.

There are a few more impls in other files, but none of them have this construct. All others are IA2 and should remain in place to comply with spec.
Attachment #312280 - Flags: review?(aaronleventhal)
(Assignee)

Comment 2

10 years ago
Comment on attachment 312280 [details] [diff] [review]
Remove the "if isempty then return false" blocks from MSAA related methods.

Forgot that Aaron is on the definitive move this weekend...
Attachment #312280 - Flags: review?(aaronleventhal) → review?(surkov.alexander)

Comment 3

10 years ago
Comment on attachment 312280 [details] [diff] [review]
Remove the "if isempty then return false" blocks from MSAA related methods.

r=me
Attachment #312280 - Flags: review?(surkov.alexander)
Attachment #312280 - Flags: review+
Attachment #312280 - Flags: approval1.9?
Comment on attachment 312280 [details] [diff] [review]
Remove the "if isempty then return false" blocks from MSAA related methods.

a=beltzner
Attachment #312280 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed

Comment 5

10 years ago
/cvsroot/mozilla/accessible/src/msaa/nsAccessibleWrap.cpp,v  <--  nsAccessibleWrap.cpp
new revision: 1.117; previous revision: 1.116
done

Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Depends on: 438784
You need to log in before you can comment on or make changes to this bug.