Closed Bug 425753 Opened 17 years ago Closed 16 years ago

Send notification when download manager finishes building the list

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This would be useful for tests and perhaps extensions.. or anything that should happen when the list finishes populating. dm-ui-done
Attached patch v1 (obsolete) — Splinter Review
No testcase changes quite yet... http://ed.agadak.net/dm.ui.done.patch
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #312320 - Flags: review?(sdwilsh)
Attached patch v1.1Splinter Review
Changed topic and subject to be "download-manager-ui-done" and download manager window. Sample updated testcase included.
Attachment #312320 - Attachment is obsolete: true
Attachment #312334 - Flags: review?(sdwilsh)
Attachment #312320 - Flags: review?(sdwilsh)
Comment on attachment 312334 [details] [diff] [review] v1.1 Looks good, but can you also fix the following tests: browser_basic_functionality.js browser_bug_394039.js browser_bug_406857.js browser_bug_410289.js browser_bug_411172.js browser_bug_411172_mac.js browser_bug_412360.js browser_bug_413093.js browser_bug_413985.js browser_bug_416303.js browser_cleanup_search.js Thanks - this cleans our tests up a whole lot, and gives people a good model to work off of!
Attachment #312334 - Flags: review?(sdwilsh)
Comment on attachment 312334 [details] [diff] [review] v1.1 I thought I actually marked this as r+... The issues mentioned in the previous comment can land afterwards as NPOTDB without approval. Drivers, this is a low-low risk patch that let's us test the download manager UI a lot easier and will greatly simplify the work required to generate a UI test.
Attachment #312334 - Flags: review+
Attachment #312334 - Flags: approval1.9?
Comment on attachment 312334 [details] [diff] [review] v1.1 a1.9=beltzner
Attachment #312334 - Flags: approval1.9? → approval1.9+
Shawn, I'll try landing this on windows as well -- moving the testcase back into the general list instead of "not on windows" list.
Checking in toolkit/mozapps/downloads/content/downloads.js; /cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v <-- downloads.js new revision: 1.144; previous revision: 1.143 done Checking in toolkit/mozapps/downloads/tests/browser/Makefile.in; /cvsroot/mozilla/toolkit/mozapps/downloads/tests/browser/Makefile.in,v <-- Makefile.in new revision: 1.22; previous revision: 1.21 done Checking in toolkit/mozapps/downloads/tests/browser/browser_multiword_search.js; /cvsroot/mozilla/toolkit/mozapps/downloads/tests/browser/browser_multiword_search.js,v <-- browser_multiword_search.js new revision: 1.4; previous revision: 1.3 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Hrm. So the test still doesn't work on windows, so bug 419691 is still open. chrome://mochikit/content/browser/toolkit/mozapps/downloads/tests/browser/browser_multiword_search.js FAIL - Search matched both downloads - chrome://mochikit/content/browser/toolkit/mozapps/downloads/tests/browser/browser_multiword_search.js FAIL - Found the single download - chrome://mochikit/content/browser/toolkit/mozapps/downloads/tests/browser/browser_multiword_search.js I'm not sure exactly why it's not happy on windows..
(quoting comment #4) > The issues mentioned in the previous comment can land afterwards as NPOTDB > without approval.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 433045
Closing, opened spin off bug 433045 for the follow up work.
Status: REOPENED → RESOLVED
Closed: 17 years ago16 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: