425753 - Send notification when download manager finishes building the list

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

This would be useful for tests and perhaps extensions.. or anything that should happen when the list finishes populating.

dm-ui-done

Comment 1

[Ed Lee :Mardak]

Attachment: v1

No testcase changes quite yet...

http://ed.agadak.net/dm.ui.done.patch

Comment 2

[Ed Lee :Mardak]

Attachment: v1.1

Changed topic and subject to be "download-manager-ui-done" and download manager window.

Sample updated testcase included.

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 312334 [details] [diff] [review]
v1.1

Looks good, but can you also fix the following tests:
browser_basic_functionality.js
browser_bug_394039.js
browser_bug_406857.js
browser_bug_410289.js
browser_bug_411172.js
browser_bug_411172_mac.js
browser_bug_412360.js
browser_bug_413093.js
browser_bug_413985.js
browser_bug_416303.js
browser_cleanup_search.js

Thanks - this cleans our tests up a whole lot, and gives people a good model to work off of!

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 312334 [details] [diff] [review]
v1.1

I thought I actually marked this as r+...

The issues mentioned in the previous comment can land afterwards as NPOTDB without approval.

Drivers, this is a low-low risk patch that let's us test the download manager UI a lot easier and will greatly simplify the work required to generate a UI test.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 312334 [details] [diff] [review]
v1.1

a1.9=beltzner

Comment 6

[Ed Lee :Mardak]

Shawn, I'll try landing this on windows as well -- moving the testcase back into the general list instead of "not on windows" list.

Comment 7

[Ed Lee :Mardak]

Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.144; previous revision: 1.143
done
Checking in toolkit/mozapps/downloads/tests/browser/Makefile.in;
/cvsroot/mozilla/toolkit/mozapps/downloads/tests/browser/Makefile.in,v  <--  Makefile.in
new revision: 1.22; previous revision: 1.21
done
Checking in toolkit/mozapps/downloads/tests/browser/browser_multiword_search.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/tests/browser/browser_multiword_search.js,v  <--  browser_multiword_search.js
new revision: 1.4; previous revision: 1.3
done

Comment 8

[Ed Lee :Mardak]

Hrm. So the test still doesn't work on windows, so bug 419691 is still open.

chrome://mochikit/content/browser/toolkit/mozapps/downloads/tests/browser/browser_multiword_search.js
	FAIL - Search matched both downloads - chrome://mochikit/content/browser/toolkit/mozapps/downloads/tests/browser/browser_multiword_search.js
	FAIL - Found the single download - chrome://mochikit/content/browser/toolkit/mozapps/downloads/tests/browser/browser_multiword_search.js

I'm not sure exactly why it's not happy on windows..

Comment 9

[Shawn Wilsher :sdwilsh]

(quoting comment #4)
> The issues mentioned in the previous comment can land afterwards as NPOTDB
> without approval.

Comment 10

[Matthew Gregan [:kinetik]]

Closing, opened spin off bug 433045 for the follow up work.