Closed Bug 425798 Opened 17 years ago Closed 17 years ago

Autocomplete no longer works in Enter Location dialog

Categories

(Firefox :: Address Bar, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: jruderman, Assigned: Gavin)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Steps to reproduce: 1. Hide the navigation bar by clicking the button in the upper-right corner of the window. 2. Cmd+L. 3. Type 's'. Expected results: autocomplete, with Slashdot as the first choice. Actual results: * Call to xpconnect wrapped JSObject produced this error: * [Exception... "'[JavaScript Error: "Ci is not defined" {file: "chrome://global/content/bindings/autocomplete.xml" line: 655}]' when calling method: [nsIAutoCompleteInput::popupOpen]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "<unknown>" data: yes] This worked fine in this morning's nightly build, so it's probably a regression from the patch in bug 404438 that went in an hour ago.
Flags: blocking-firefox3?
Argh, I'll fix.
Attached patch patch (obsolete) — Splinter Review
This is obvious, I'm landing with r+a=bustage.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attached patch real patchSplinter Review
Attachment #312359 - Attachment is obsolete: true
Fixed. mozilla/toolkit/content/widgets/autocomplete.xml 1.129 (search.xml doesn't need the fix because it always shares scope with browser.js).
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: blocking-firefox3? → blocking-firefox3+
Verified FIXED using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008050804 Minefield/3.0pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: