425834 - SHOWFOR doesn't hide text with headings

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P2)

Description

[Chris Ilias [:cilias]]

Does not hide text:

{SHOWFOR(os=linux)}
!level 1 heading
text
{SHOWFOR}


Does hide text:

!level 1 heading
{SHOWFOR(os=linux)}
text
{SHOWFOR}

Further testing: <http://support.mozilla.com/en-US/kb/Testing>

Comment 1

[Chris Ilias [:cilias]]

Judging from some other articles it doesn't seem dependent on headings. I not sure what the circumstances are, to replicate this.

Comment 2

[Chris Ilias [:cilias]]

With further testing, it appears to be specific to level 1 headings (!).

Comment 3

[Chris Ilias [:cilias]]

Note: http://support.mozilla.com/en-US/kb/Firefox+crashes+when+using+Yahoo+Mail needs to be updated, when this bug is fixed. It's currently using a workaround.

Comment 4

[Chris Ilias [:cilias]]

And http://support.mozilla.com/en-US/kb/Could+not+initialize+the+browser+security+component

Comment 5

[Nelson Ko [:nkoth]]

The problem was caused by javascript unsuccessfully attempting to change the visibility of the table of contents entry of the heading within the SHOWFOR in the cases where there is no table of contents on the page. This is solved by making the javascript check for the existence of that table of contents entry before trying to do anything.

Fix in r17666/r17667

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Removing "push-needed" keyword since this has been deployed to production.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

While the underlying bug is verified fixed (based on my testing of it in http://support.mozilla.com/en-US/kb/Testing), the two URLs in comment 3 and comment 4 should be fixed; Chris, could you do the honors?  Thanks!

Comment 8

[Chris Ilias [:cilias]]

The URLs in comment 3 and comment 4 are currently using workarounds (allow HTML, and use <h2>). I'll test them out now.

Comment 9

[Chris Ilias [:cilias]]

Yup. Verified.