426322 - native ComboBox arrow is not rendered correctly with GNOME nimbus theme

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Ginn Chen]

Filed from Bug 415830 comment 31 - 33

Screenshot at https://bugzilla.mozilla.org/attachment.cgi?id=310214

This bug is important on Solaris, because nimbus is the default theme of Solaris Nevada.

I checked nimbus engine source code, for gtk_paint_arrow, it queries allocation of arrow widget's grandparent, and width of GtkVSeparator.

I don't know whether it is correct to do so in gtk_paint_arrow().
I proposed a patch to get around.

Comment 1

[Ginn Chen]

Attachment: patch

gComboBoxArrowWidget's grandparent is gComboBoxButtonWidget.
Setting allocate of gComboBoxWidget will apply to both gComboBoxButtonWidget and gComboBoxSeparatorWidget.

Comment 2

[Damon Sicore (:damons)]

Need a testcase here.  Approval pending test.

Comment 3

[Damon Sicore (:damons)]

Comment on attachment 312892 [details] [diff] [review]
patch

re-request approval when we have a test.

Comment 4

[Ginn Chen]

testcase can be https://bugzilla.mozilla.org/query.cgi or any page with OPTION

Do I need to add it to somewhere?

Comment 5

[Reed Loden [:reed]]

This isn't something that can be automatically tested, as it's an issue with one particular GNOME theme. You could do a Litmus test for it, I guess, but that's pushing it.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 312892 [details] [diff] [review]
patch

a=beltzner, and yes, a litmus test would be good

Comment 7

[Ginn Chen]

Checking in gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.105; previous revision: 1.104
done

Comment 8

[Ginn Chen]

https://litmus.mozilla.org/show_test.cgi?id=5271