If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Wrong plugin icon size used

RESOLVED FIXED in Firefox 3

Status

()

Firefox
Theme
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: micmon, Assigned: reed)

Tracking

Trunk
Firefox 3
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Reporter)

Description

10 years ago
The plugin notification uses the the large (32x32) icon where it should use the small (16x16) one.
(Reporter)

Comment 1

10 years ago
Created attachment 313005 [details]
Screenshot

Shows caled down icon and 16x16 icon to compare
(Assignee)

Comment 2

10 years ago
We need a 16x16 plugin icon to fix this... It affects all platforms.
OS: Linux → All
Hardware: PC → All
Blocks: 428923
(Reporter)

Comment 3

10 years ago
The 16x16 plugin icon should already be there somewhere... if not I can attach it again.
(Assignee)

Comment 4

10 years ago
I see a 16x16 version as part of toolkit/themes/gnomestripe/mozapps/extensions/viewButtons.png, but I need a standalone version of it.
(Reporter)

Comment 5

10 years ago
Created attachment 316565 [details]
Plugins 16x16

No problem, here it is
(Assignee)

Comment 6

10 years ago
Mossop, thoughts on where this icon should go and what name to use for it? Maybe toolkit/themes/*stripe/mozapps/plugins/pluginGeneric-16.png or something? dunno... :/
Variant naming seems to be pretty inconsistent but I think the name you have there is sensible.
(Assignee)

Comment 8

10 years ago
faaborg, need 16x16 icons for winstripe and pinstripe for this, too.
Created attachment 318003 [details]
Aero plugin icon
Created attachment 318004 [details]
Luna plugin icon
Stephen: can you post the 16x16 plugin icon for proto

Comment 12

10 years ago
I thought the 16x16 plugin icon already existed in browser/preferences for use in the handler picker?
Yes, we already have it at: http://mxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/preferences/plugin.png
(Assignee)

Comment 14

10 years ago
I can't use an icon from browser/ for something in toolkit/, so I might just move the icon over to toolkit and update both places to use that icon so that we don't have two copies of the same thing.
(Assignee)

Comment 15

10 years ago
Comment on attachment 316565 [details]
Plugins 16x16

Requesting approval to land this for gnomestripe. winstripe just got this landed earlier tonight.
Attachment #316565 - Flags: approval1.9?
Comment on attachment 316565 [details]
Plugins 16x16

a1.9+=damons
Attachment #316565 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
(Assignee)

Comment 17

10 years ago
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/plugins/pluginGeneric-16.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/plugins/pluginGeneric-16.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/plugins/pluginGeneric-16.png,v  <--  pluginGeneric-16.png
initial revision: 1.1
done
Keywords: checkin-needed
(Assignee)

Comment 18

10 years ago
Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.13; previous revision: 1.12
done
(Assignee)

Comment 19

10 years ago
Created attachment 319763 [details] [diff] [review]
patch - v1

This finishes moving the icon to toolkit and swaps the use of the 32x32 icon to the 16x16 one.
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #319763 - Flags: review?(mano)
Comment on attachment 319763 [details] [diff] [review]
patch - v1

r=mano
Attachment #319763 - Flags: review?(mano) → review+
(Assignee)

Comment 21

10 years ago
Comment on attachment 319763 [details] [diff] [review]
patch - v1

Simple patch to use the correct icon for plugin notification bar.
Attachment #319763 - Flags: approval1.9?
Comment on attachment 319763 [details] [diff] [review]
patch - v1

a1.9=beltzner
Attachment #319763 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 23

10 years ago
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.1032; previous revision: 1.1031
done
Checking in browser/themes/gnomestripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.80; previous revision: 1.79
done
Checking in browser/themes/gnomestripe/browser/preferences/applications.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/applications.css,v  <--  applications.css
new revision: 1.4; previous revision: 1.3
done
Removing browser/themes/gnomestripe/browser/preferences/plugin.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/plugin.png,v  <--  plugin.png
new revision: delete; previous revision: 1.4
done
Checking in browser/themes/pinstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/pinstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.89; previous revision: 1.88
done
Checking in browser/themes/pinstripe/browser/preferences/applications.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/preferences/applications.css,v  <--  applications.css
new revision: 1.4; previous revision: 1.3
done
Removing browser/themes/pinstripe/browser/preferences/plugin.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/preferences/plugin.png,v  <--  plugin.png
new revision: delete; previous revision: 1.3
done
Checking in browser/themes/winstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/winstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.97; previous revision: 1.96
done
Checking in browser/themes/winstripe/browser/preferences/applications.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/applications.css,v  <--  applications.css
new revision: 1.3; previous revision: 1.2
done
Removing browser/themes/winstripe/browser/preferences/plugin.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/plugin.png,v  <--  plugin.png
new revision: delete; previous revision: 1.5
done
Checking in toolkit/themes/pinstripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.28; previous revision: 1.27
done
RCS file: /cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/plugins/pluginGeneric-16.png,v
done
Checking in toolkit/themes/pinstripe/mozapps/plugins/pluginGeneric-16.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/plugins/pluginGeneric-16.png,v  <--  pluginGeneric-16.png
initial revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
You need to log in before you can comment on or make changes to this bug.