426669 - Treehydra/Dehydra: Replace gczeal builtin function with require option

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[David Mandelin [:dmandelin]]

The same semantics should be provided via an option to the require builtin with the name 'gczeal' and the argument type integer. (JS_GCZeal takes a uint8, but I'm guessing it's not worth trying to check that the argument fits in a uint8.)

Comment 1

[(dormant account)]

Attachment: gczeal support for require

Comment 2

[David Mandelin [:dmandelin]]

(In reply to comment #1)
> Created an attachment (id=317801) [details]
> gczeal support for require

- Your test case already passes. I couldn't think of a reasonable way to reliably test this feature, so unless you can, take it out.
 
- The warning messages confused me. I'm still confused, because it turns out they don't correspond with how I've been building xhydra, namely by defining JS_GC_ZEAL in my config file, but not DEBUG. But presumably that is weird because it would only work if you had build SM with DEBUG, which you should then define again for using it. Assuming I've got that right, can I copy-edit the warnings to:

  "gczeal not enabled: xhydra built with a SpiderMonkey version lacking JS_SetGCZeal"

and
 
  "gczeal not enabled: xhydra built without -DDEBUG"

Looks good with those changes.

Comment 3

[(dormant account)]

pushed

Comment 4

[David Mandelin [:dmandelin]]

Comment on attachment 317801 [details] [diff] [review]
gczeal support for require

Cleaning up ancient review requests.