426681 - FF3RC1 should use NSS_3_12_RC2

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P2)

Description

[Kai Engert (:KaiE:)]

We want to deliver a NSS 3.12 release candidate snapshot for Firefox 3 RC 1.

Comment 1

[Kai Engert (:KaiE:)]

We must decide on a name for the snapshot.
Shall it be Beta 4 or RC 1?
Should the NSS snapshot identify itself as a beta or as a release candidate?

Wan-Teh, please feel free to propose an updated NSPR tag at the same time.

This bug depends on adding the new roots that we want to get into FF3, bug 425469.

This one blocks bug 425518.

Comment 2

[Kai Engert (:KaiE:)]

We have decided to call it RC1 and have it identify itself as a release, not a beta.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

We want to try to resolve bug 400238 and bug 303457 before RC1.

Comment 4

[Damon Sicore (:damons)]

Why would creating a NSS snapshot block the release of Firefox 3?

Seems like no matter what, Firefox 3 will ship with _some_ version of NSS regardless of what it's called, right? 

-'ing this, but if what you are trying to say is that Firefox 3 must have a new version of NSS for us to ship (or some other reason that's different from my interpretation above), then please re-nom.  :)

Comment 5

[Reed Loden [:reed]]

(In reply to comment #4)
> -'ing this, but if what you are trying to say is that Firefox 3 must have a new
> version of NSS for us to ship (or some other reason that's different from my
> interpretation above), then please re-nom.  :)

Firefox 3 must have a new version of NSS for bugs like bug 425518 and other NSS issues.

Comment 6

[Damon Sicore (:damons)]

(In reply to comment #5)
> (In reply to comment #4)
> > -'ing this, but if what you are trying to say is that Firefox 3 must have a new
> > version of NSS for us to ship (or some other reason that's different from my
> > interpretation above), then please re-nom.  :)
> 
> Firefox 3 must have a new version of NSS for bugs like bug 425518 and other NSS
> issues.
> 

OK.  This makes sense.  Thanks for the explanation.  Blocking.

Comment 7

[Christophe Ravel]

Version of NSS changed to NSS 3.12.0.0 to prepare NSS 3.12 RC1.

Checking in manifest.mn;
/cvsroot/mozilla/security/nss/manifest.mn,v  <--  manifest.mn
new revision: 1.20; previous revision: 1.19
done
Checking in lib/nss/nss.h;
/cvsroot/mozilla/security/nss/lib/nss/nss.h,v  <--  nss.h
new revision: 1.55; previous revision: 1.54
done
Checking in lib/softoken/softkver.h;
/cvsroot/mozilla/security/nss/lib/softoken/softkver.h,v  <--  softkver.h
new revision: 1.3; previous revision: 1.2
done

Comment 8

[Kai Engert (:KaiE:)]

Note that bug 425469 has been fixed for NSS 3.12.
(The bug is being kept open for landing on another branch)

Comment 9

[Kai Engert (:KaiE:)]

Attachment: Patch v1

Comment 10

[Robert Relyea]

Comment on attachment 314050 [details] [diff] [review]
Patch v1

r+ rrelyea

Comment 11

[Kai Engert (:KaiE:)]

checked in, marking fixed.

Comment 12

[Kai Engert (:KaiE:)]

I have to reopen this bug, because I had to revert Mozilla to the previous beta3 tag.

The landing of RC1 caused bug 427706.

Comment 13

[Kai Engert (:KaiE:)]

Attachment: Patch v2

We've backed out the patch that caused the regression.

Comment 14

[Robert Relyea]

Comment on attachment 314394 [details] [diff] [review]
Patch v2

r+

Comment 15

[Kai Engert (:KaiE:)]

changing subject to RC2

Comment 16

[Kai Engert (:KaiE:)]

checked in again

This time it looks good, the machine the reported the failure yesterday has now passed a full cycle with green.

Marking fixed again.