426721 - Transforming the ancestors of a foreignObject does not cause a refresh

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Markus Mobius]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4

Login to above URL - use the username "readinggroup" and same password. You will see a data entry web program that makes extensive use of SVG foreignobject and general SVG improvements in FF3. The code worked perfectly in FF3 Beta 1 to 4. In Beta 5 the page becomes very slow and no longer renders correctly.
Examples:
* R and C keys should rotate the image - this works in Beta 4 but not Beta 5.
* Press Page Up twice to go to next census image - a warning page appears - but afterwards the underlying image is rendered incorrectly. 
* When you scroll the image using the A and Z keys there are parts of the image that are not scrolled. 



Reproducible: Always

Steps to Reproduce:
1.Login to above URL - use the username "readinggroup" and same password.
2.R and C keys should rotate the image - this works in Beta 4 but not Beta 5.
3.Press Page Up twice to go to next census image - a warning page appears - but afterwards the underlying image is rendered incorrectly.
Actual Results:  
Program works in Beta 1 to Beta 4 but not Beta 5 on Windows Vista.

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

I removed the reflow = PR_TRUE line which was a little too aggressive. We need the UpdateGraphic call.

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

right file this time.

Comment 3

[Robert Longson [:longsonr]]

Comment on attachment 313324 [details] [diff] [review]
patch

Very low risk as previous betas of firefox 3 used to call UpdateGraphic at this point. I've checked that the infinite loop testcases that prompted the original change are still OK.

Comment 4

[Damon Sicore (:damons)]

Robert, thanks for indicating risk and confirming tests pass.  

Comment 5

[Damon Sicore (:damons)]

Comment on attachment 313324 [details] [diff] [review]
patch

a1.9+=damons

Comment 6

[Robert Longson [:longsonr]]

checked in,