426738 - SVG text in hyperlink appears to have incorrect length

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Duncan Loveday]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040112 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040112 Minefield/3.0pre

Some SVG hyperlinks containing text appear to have a "mouse active" region (if that is the right term) not covering the whole of the text.

Reproducible: Always

Steps to Reproduce:
1. Open this attachment https://bugzilla.mozilla.org/attachment.cgi?id=312910 from bug 425662
2. Click on the word "me" within "click me"
3.
Actual Results:  
Nothing happens

Expected Results:  
The hyperlink should activate, displaying an alert.

The hyperlink is only activated when clicking on the word "click" within "click me".

Comment 1

[Duncan Loveday]

Regressed at the same time as bug 425662, i.e. between

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2008-03-18-06-trunk/firefox-3.0b5pre.en-US.win32.installer.exe

and

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2008-03-19-05-trunk/firefox-3.0b5pre.en-US.win32.installer.exe

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Hmm, why is this correct? MeasureText returns appunits, so shouldn't we be doing SetupForMetrics?

Comment 4

[Robert Longson [:longsonr]]

Attachment: simpler testcase

Comment 5

[Robert Longson [:longsonr]]

Attachment: text and textPath testcase

Comment 6

[Robert Longson [:longsonr]]

(In reply to comment #3)
> Hmm, why is this correct? MeasureText returns appunits, so shouldn't we be
> doing SetupForMetrics?
> 

My new testcase shows you are right. The patch breaks textPath (which currently works). I'll try to figure out what it is about textPath that is working when text is not.

Comment 7

[Robert Longson [:longsonr]]

Attachment: corrected patch

The advance width is in app units.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 313955 [details] [diff] [review]
corrected patch

Bingo! Good work!

Comment 9

[Robert Longson [:longsonr]]

Comment on attachment 313955 [details] [diff] [review]
corrected patch

Simple fix for a recent regression.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 313955 [details] [diff] [review]
corrected patch

a1.9=beltzner

Comment 11

[Robert Longson [:longsonr]]

checked in