426950 - Junk mail controls not run on Place a Copy In -> Other folder even when not saving sent mail

Status: RESOLVED DUPLICATE of bug 389098

(MailNews Core :: Filters, defect)

Description

[Erin Spiceland]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.12) Gecko/20080208 Fedora/2.0.0.12-1.fc8 Firefox/2.0.0.12
Build Identifier: 2.0.0.12 20080226

I have tested this and confirmed that this is the case in my 2.0.0.12 TB: Even if the "Place a copy in" checkbox under Preferences -> Account -> Copies & Folders is unchecked (ie, no sent mail saved), junk mail controls do not run on the selected folder, even though it is greyed out, indicating that it is not a sent mail folder.  

Reproducible: Always

Steps to Reproduce:
1. In Account Settings -> Account -> Copies and Folders, with the "Place a copy in" checkbox checked, select the "Other" radio button and choose a folder which accumulates lots of spam.
2. Uncheck the "Place a copy in" checkbox.  The "Other" radio button will still be selected, but it and the folder drop down box will be greyed out.
3. Even though no sent mail is being saved in the folder, junk mail controls will not run on that folder.
Actual Results:  
Junk mail controls are not run on the selected folder, even though that folder is not set as a sent mail folder.

Expected Results:  
Junk mail controls should run.  TB should check not only if the folder is selected, but also if the "Place a copy in" checkbox is checked.

Comment 1

[Kent James (:rkent)]

Confirmed by me in bug 329569 comment 35.

Comment 2

[Kent James (:rkent)]

While doing final checks for bug 198100, I encountered an issue that might be the same as this bug.

STR:

1) Create a filter on an IMAP server that moves a message to a local folder.
2) enable junk processing on the local server.
3) send a spam message to the IMAP server.

Expected results: junk processing runs on the local message after it reaches the folder.

Actual results: junk processing does not run.

I traced this, and CallFilterPlugins is being called on the local folder, but there are no new messages. When the new database header is being created for the new local message, the flags it is seeing are for the moved and deleted IMAP message - which does not have the NEW flag set.

Comment 3

[Kent James (:rkent)]

Attachment: Persist flags in the copy state

This solves my current symptoms. I need to see if it solves the original STR of this bug.

IMAP was sending \SEEN \DELETED flags to the server for the moved message before the local message header was created. When the IMAP response was received, the IMAP protocol then set the READ flag on the old message header, which was preventing it from being added to the new list, which prevented spam processing from being run on it.

Comment 4

[Ingo Fischer]

Hi, 

this sounds like the problems I have reported in #389098 and #389096.

What do you think?!

Ingo F

Comment 5

[Kent James (:rkent)]

(In reply to comment #4)
> this sounds like the problems I have reported in #389098 and #389096.

Yes, I think you are right. Rereading this bug with more time on my hands (unlike last night when I just wanted to dump my new problem somewhere) I think it is closer to bug 389098 - though bug 329569 comment 29 by you is the clearest description. I'll continue my work under bug 389098 (even though the definition of that bug has drifted awasy from the STR in bug 329569 comment 29).

Comment 6

[:aceman]

So is this a duplicate of any of those bugs? What to do with the patch here?

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to :aceman from comment #6)
> So is this a duplicate of any of those bugs? What to do with the patch here?

obsolete?

how does this relate to bug 339931?  (ref rkent's bug 339931 comment 9)

Comment 8

[:aceman]

Erin, what is the icon on the folder chosen in step 1 that is not running junk controls?

I've noticed that when you had a folder being the target for Junk or Sent and you disable the option ("run junk mail controls" or "Place a copy in" checkbox) the folder that was the last target does not loose its special icon. Presumably it also keeps the special folder flag (nsMsgFolderFlags::Archive | nsMsgFolderFlags::SentMail |
nsMsgFolderFlags::Junk) So maybe when junk processing encounters this SentMail flag on the folder it skips it as described in comment 0.

Comment 9

[:aceman]

"run junk mail controls" checkbox should have been "move new junk messages to".

It is as if the code here:
http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsSpamSettings.cpp#431

Does not clear the flag if no new target folder is set. Something similar may happen for the Sent folder.

Comment 10

[Erin Spiceland]

(In reply to :aceman from comment #8)
> Erin, what is the icon on the folder chosen in step 1 that is not running
> junk controls?

Sorry, I don't know. I haven't used Thunderbird in forever.